[NanoAOD] Adding correct Iso filter name (without cut values) for Run3 #39230

wonpoint4 · 2022-08-29T10:14:45Z

PR description:

Adding correct Iso filter name (without cut values) for Run3
Relevant JIRA ticket : https://its.cern.ch/jira/browse/CMSHLT-2312

And I was wondering that I have to make backport PRs to the both of 124X and 125X.

cmsbuild · 2022-08-29T10:23:09Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39230/31855

This PR adds an extra 16KB to repository

cmsbuild · 2022-08-29T10:23:33Z

A new Pull Request was created by @wonpoint4 (Won Jun) for master.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)

@cmsbuild, @mariadalfonso, @gouskos, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @swertz this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

perrotta · 2022-09-05T06:01:04Z

please test

cmsbuild · 2022-09-05T08:49:39Z

-1

Failed Tests: UnitTests RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-50442b/27329/summary.html
COMMIT: 994c5b6
CMSSW: CMSSW_12_6_X_2022-09-04-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39230/27329/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test runtestPhysicsToolsNanoAOD had ERRORS

RelVals

136.8523

----- Begin Fatal Exception 05-Sep-2022 09:10:43 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=TriggerObjectTableProducer label='triggerObjectTable'
Exception Message:
Expression parser error:Missing close parenthesis. (char 153)
----- End Fatal Exception -------------------------------------------------

1325.81

----- Begin Fatal Exception 05-Sep-2022 09:15:21 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=TriggerObjectTableProducer label='triggerObjectTable'
Exception Message:
Expression parser error:Missing close parenthesis. (char 153)
----- End Fatal Exception -------------------------------------------------

11634.7

----- Begin Fatal Exception 05-Sep-2022 09:30:29 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=TriggerObjectTableProducer label='triggerObjectTable'
Exception Message:
Expression parser error:Missing close parenthesis. (char 153)
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

136.7952136.7952_RunJetHT2017C_94Xv2NanoAODINPUT+RunJetHT2017C_94Xv2NanoAODINPUT+NANOEDM2017_94XMiniAODv2+HARVESTNANOAOD2017_94XMiniAODv2/step2_RunJetHT2017C_94Xv2NanoAODINPUT+RunJetHT2017C_94Xv2NanoAODINPUT+NANOEDM2017_94XMiniAODv2+HARVESTNANOAOD2017_94XMiniAODv2.log
136.8523136.8523_RunJetHT2018C_nanoULremini+RunJetHT2018C_nanoULremini+NANOEDM2018_106Xv2+HARVESTNANOAOD2018_106Xv2/step2_RunJetHT2018C_nanoULremini+RunJetHT2018C_nanoULremini+NANOEDM2018_106Xv2+HARVESTNANOAOD2018_106Xv2.log
136.8521136.8521_RunJetHT2018A_nano+RunJetHT2018A_nano+NANOEDM2018_102Xv1+HARVESTNANOAOD2018_102Xv1/step2_RunJetHT2018A_nano+RunJetHT2018A_nano+NANOEDM2018_102Xv1+HARVESTNANOAOD2018_102Xv1.log

Expand to see more relval errors ...

cmsbuild · 2022-09-06T12:08:26Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39230/32012

This PR adds an extra 16KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/NanoAOD/python/triggerObjects_cff.py modified in PR(s): Adding photon and muon leg trigger filters of HLT_Mu17_Photon30_IsoCa… #39309

cmsbuild · 2022-09-06T12:08:48Z

Pull request #39230 was updated. @cmsbuild, @swertz, @vlimant can you please check and sign again.

vlimant · 2022-09-06T14:18:34Z

integration test running https://gitlab.cern.ch/cms-nanoAOD/nanoAOD-integration/-/issues/178

vlimant · 2022-09-14T13:22:16Z

please test

cmsbuild · 2022-09-14T17:48:08Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-50442b/27536/summary.html
COMMIT: 5d1b6c6
CMSSW: CMSSW_12_6_X_2022-09-13-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39230/27536/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 10 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3618326
DQMHistoTests: Total failures: 66
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3618238
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: no differences found

wonpoint4 · 2022-09-23T12:02:00Z

Dear experts,
I couldn't understand the origin of error (The relvals timed out after 4 hours.)
Could you give me an advice or suggestion here?

perrotta · 2022-09-23T13:03:21Z

please test

cmsbuild · 2022-09-23T16:59:19Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-50442b/27750/summary.html
COMMIT: 5d1b6c6
CMSSW: CMSSW_12_6_X_2022-09-22-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39230/27750/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3624368
DQMHistoTests: Total failures: 60
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3624286
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: no differences found

swertz · 2022-10-10T07:29:36Z

+xpog

And I was wondering that I have to make backport PRs to the both of 124X and 125X.

That won't be necessary, 124X is closed for Nano and there will be no re-nano in 125X.

cmsbuild · 2022-10-10T07:30:01Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2022-10-10T13:54:08Z

+1

silviodonato · 2022-10-20T08:07:23Z

Related to https://its.cern.ch/jira/browse/CMSHLT-2312

And I was wondering that I have to make backport PRs to the both of 124X and 125X.

That won't be necessary, 124X is closed for Nano and there will be no re-nano in 125X.

This creates problem about the maintenance of the PromptNano AOD when the HLT menu changes during the datataking. We need a larger discussion about this.

In any case, @wonpoint4 is your PR compatible with the HLT menu both before and after CMSHLT-2312, or only after CMSHLT-2312 (ie. it should be compatible with both HLT v1.2 and HLT v1.3)

silviodonato · 2022-10-20T08:09:40Z

cc: @jordan-martins

wonpoint4 · 2022-10-20T08:44:57Z

In any case, @wonpoint4 is your PR compatible with the HLT menu both before and after CMSHLT-2312, or only after CMSHLT-2312 (ie. it should be compatible with both HLT v1.2 and HLT v1.3)

Yes, this PR is supposed to be compatible with HLT menu before/after CMSHLT-2312, like compatible with menu during the whole Run3, and even the Run2.

swertz · 2022-10-27T08:19:11Z

And I was wondering that I have to make backport PRs to the both of 124X and 125X.

We have now decided that we would backport changes to the trigger object filter names to 124X to allow prompt nano to pick up those changes, even if it breaks compatibility with Run2 or existing V10 samples. Can you please make a backport to 124X @wonpoint4 ?

In principle the same changes should then also be applied to the frozen V10 config in master: https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/python/V10/triggerObjects_cff.py

swertz · 2022-11-02T08:13:11Z

@wonpoint4 with the backport merged we now have an inconsistency between the nanoV10 in 124X and the frozen V10 config in master. Can I ask you to make another PR to master to apply the same changes to https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/python/V10/triggerObjects_cff.py ?

Adding correct Iso filter name (without cut values) for Run3

994c5b6

cmsbuild added this to the CMSSW_12_6_X milestone Aug 29, 2022

cmsbuild added code-checks-pending orp-pending pending-signatures tests-pending xpog-pending labels Aug 29, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 29, 2022

cmsbuild added tests-started and removed tests-pending labels Sep 5, 2022

cmsbuild added tests-rejected and removed tests-started labels Sep 5, 2022

cmsbuild mentioned this pull request Sep 5, 2022

Adding photon and muon leg trigger filters of HLT_Mu17_Photon30_IsoCa… #39309

Merged

Remove max(a,b,c)

5d1b6c6

cmsbuild added code-checks-pending tests-pending and removed tests-rejected code-checks-approved labels Sep 6, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 6, 2022

cmsbuild removed the tests-pending label Sep 14, 2022

cmsbuild added tests-rejected and removed tests-started labels Sep 14, 2022

cmsbuild mentioned this pull request Sep 20, 2022

LHE generic mass filter extension #39458

Closed

cmsbuild added tests-started and removed tests-rejected labels Sep 23, 2022

cmsbuild added tests-approved and removed tests-started labels Sep 23, 2022

cmsbuild mentioned this pull request Oct 6, 2022

HLT Tau DQM from MiniAOD #39647

Closed

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels Oct 10, 2022

rappoccio merged commit c9b6f18 into cms-sw:master Oct 10, 2022

cmsbuild added orp-approved and removed orp-pending labels Oct 10, 2022

swertz mentioned this pull request Oct 28, 2022

Nano: fix matching between pat trigger objects and L1 objects #39893

Merged

wonpoint4 mentioned this pull request Oct 28, 2022

[Backport] Adding correct Iso filter name (without cut values) for Run3 #39894

Merged

wonpoint4 mentioned this pull request Nov 2, 2022

[NanoAOD V10] - Adding correct Iso filter name (without cut values) for Run3 #39956

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NanoAOD] Adding correct Iso filter name (without cut values) for Run3 #39230

[NanoAOD] Adding correct Iso filter name (without cut values) for Run3 #39230

wonpoint4 commented Aug 29, 2022

cmsbuild commented Aug 29, 2022

cmsbuild commented Aug 29, 2022

perrotta commented Sep 5, 2022

cmsbuild commented Sep 5, 2022

cmsbuild commented Sep 6, 2022

cmsbuild commented Sep 6, 2022

vlimant commented Sep 6, 2022 •

edited

Loading

vlimant commented Sep 14, 2022

cmsbuild commented Sep 14, 2022

wonpoint4 commented Sep 23, 2022

perrotta commented Sep 23, 2022

cmsbuild commented Sep 23, 2022

swertz commented Oct 10, 2022

cmsbuild commented Oct 10, 2022

rappoccio commented Oct 10, 2022

silviodonato commented Oct 20, 2022

silviodonato commented Oct 20, 2022

wonpoint4 commented Oct 20, 2022

swertz commented Oct 27, 2022

swertz commented Nov 2, 2022

[NanoAOD] Adding correct Iso filter name (without cut values) for Run3 #39230

[NanoAOD] Adding correct Iso filter name (without cut values) for Run3 #39230

Conversation

wonpoint4 commented Aug 29, 2022

PR description:

cmsbuild commented Aug 29, 2022

cmsbuild commented Aug 29, 2022

perrotta commented Sep 5, 2022

cmsbuild commented Sep 5, 2022

Unit Tests

RelVals

RelVals-INPUT

cmsbuild commented Sep 6, 2022

cmsbuild commented Sep 6, 2022

vlimant commented Sep 6, 2022 • edited Loading

vlimant commented Sep 14, 2022

cmsbuild commented Sep 14, 2022

RelVals-INPUT

Comparison Summary

wonpoint4 commented Sep 23, 2022

perrotta commented Sep 23, 2022

cmsbuild commented Sep 23, 2022

Comparison Summary

swertz commented Oct 10, 2022

cmsbuild commented Oct 10, 2022

rappoccio commented Oct 10, 2022

silviodonato commented Oct 20, 2022

silviodonato commented Oct 20, 2022

wonpoint4 commented Oct 20, 2022

swertz commented Oct 27, 2022

swertz commented Nov 2, 2022

vlimant commented Sep 6, 2022 •

edited

Loading