Declare production of Track collection after TrackExtra collection in modules run at HLT

[makortel]

PR description:

This PR proposes to declare the production of Track collection after TrackExtra and TrackingRecHit collections to work around a rare scheduling bug in the framework that might have caused three failures in the HLT that were reporter in #39064 (see #39064 (comment) for the details). The problem should be specific modules run in scheduled mode (i.e. modules are in Path or Sequence). Given that in all offline workflows the reconstruction code is run unscheduled, I limited to modules that I saw were in HLT_GRun_cff. I might have missed some, but I hope these changes would reduce the rate of the failures.

PR validation:

None

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39201/31811

• This PR adds an extra 40KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoPixelVertexing/PixelTrackFitting/plugins/PixelTrackProducerFromSoA.cc modified in PR(s): Tracker Traits and Enabling Phase2 for Inner Tracker Reconstruction on GPU #38761

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

• RecoMuon/L2MuonProducer (hlt, reconstruction)
• RecoMuon/L3MuonProducer (hlt, reconstruction)
• RecoPixelVertexing/PixelTrackFitting (reconstruction)
• RecoTracker/FinalTrackSelectors (reconstruction)
• RecoTracker/TrackProducer (reconstruction)

@Martin-Grunewald, @clacaputo, @cmsbuild, @missirol, @jpata, @mandrenguyen can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @abbiendi, @CeliaFernandez, @mmusich, @cericeci, @silviodonato, @JanFSchulte, @jhgoh, @sscruz, @trocino, @rociovilar, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @ebrondol, @mtosi, @dgulhan, @HuguesBrun, @Fedespring, @gpetruc this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c7950e/27099/summary.html
COMMIT: e61e730
CMSSW: CMSSW_12_5_X_2022-08-25-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39201/27099/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3693084
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3693060
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

To be backported down to 12_4_X, as it might solve (rare) crashes seen online at HLT.

Thanks to @makortel and @Dr15Jones for this follow-up.

[jpata]

+reconstruction

• on the reco side, looks transparent / technical (if somewhat arcane)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1