-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new tag for PPS PCL, move SiStrips tags to Prod in DropBoxMetadata #39181
Conversation
@cmsbuild , please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39181/31774
|
A new Pull Request was created by @tvami (Tamas Vami) for master. It involves the following packages:
@malbouis, @yuanchao, @saumyaphor4252, @ggovi, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-92c668/27062/summary.html Comparison SummarySummary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
As requested in https://cms-talk.web.cern.ch/t/new-tag-for-pcl-for-pps-timingcalibration/14245 we moved the PPS Timing PCL tag to v1
I took the opp to fix some other metadatas for the strips (in agreement with the strips convenors)
PR validation:
The produced payload differs only in the keys where it should:
https://cern.ch/go/z8gx
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not really needed, but I think we should have it in 12_4_X, that's where it's really used