Compute/store unprefirable event information by default in MINIAOD

[lathomas]

PR description:

The information about unprefirable events was only stored for Run 2 UL reprocessing.
It is however needed also for future data taking.
This PR stores this by default, as requested in #38890 and #31985

PR validation:

Checked on recent Run 3 data that the information is indeed available at MINIAOD after this change.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport. Will need one for 12_4_X. Would highly appreciate if this fix could be deployed for Prompt Reco in the next weeks.

[lathomas]

cmssw/PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py

Line 607 in 5e9556c

run2_miniAOD_UL.toModify(task, func=lambda t: t.add(process.simGtExtUnprefireable))

I wasn't sure whether to drop this line (which becomes redundant) or not ?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39169/31758

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @lathomas for master.

It involves the following packages:

• PhysicsTools/PatAlgos (reconstruction)

@jpata, @cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@AlexDeMoor, @rappoccio, @gouskos, @jdolen, @JyothsnaKomaragiri, @ahinzmann, @schoef, @emilbols, @jdamgov, @mbluj, @nhanvtran, @gkasieczka, @hatakeyamak, @gpetruc, @azotz, @mariadalfonso, @demuller, @andrzejnovak, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[jpata]

@cmsbuild please test

[cmsbuild]

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e45d3/27090/summary.html
COMMIT: 5e9556c
CMSSW: CMSSW_12_5_X_2022-08-25-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39169/27090/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 136.7611

----- Begin Fatal Exception 25-Aug-2022 14:33:00 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 277069 lumi: 81 event: 36026102 stream: 0
   [1] Running path 'MINIAODoutput_step'
   [2] Prefetching for module PoolOutputModule/'MINIAODoutput'
   [3] Calling method for module L1TExtCondProducer/'simGtExtUnprefireable'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: TCDSRecord
Looking for module label: tcdsDigis
Looking for productInstanceName: tcdsRecord

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

• 4.53

----- Begin Fatal Exception 25-Aug-2022 14:34:52 CEST-----------------------
An exception of category 'L1TExtCondProducer' occurred while
   [0] Processing  Event run: 194533 lumi: 329 event: 461582793 stream: 0
   [1] Running path 'MINIAODoutput_step'
   [2] Prefetching for module PoolOutputModule/'MINIAODoutput'
   [3] Calling method for module L1TExtCondProducer/'simGtExtUnprefireable'
Exception Message:
Unexpectedly small L1A history from TCDSRecord: (size = 0 < 4)
----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

• 4.64.6_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1/step2_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1.log
• 136.7611136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM/step2_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM.log
• 136.7721136.7721_RunJetHT2016H_reminiaod+RunJetHT2016H_reminiaod+REMINIAOD_data2016+HARVESTDR2_REMINIAOD_data2016/step2_RunJetHT2016H_reminiaod+RunJetHT2016H_reminiaod+REMINIAOD_data2016+HARVESTDR2_REMINIAOD_data2016.log

Expand to see more relval errors ...

• 134.0
• 144.6
• 1002.0

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39169/31805

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #39169 was updated. @epalencia, @clacaputo, @cmsbuild, @rekovic, @jpata, @mandrenguyen, @cecilecaillol can you please check and sign again.

[lathomas]

@jpata does the fix for old data reprocessing seem ok. If so, would you mind triggering the tests again? Thanks !

[jpata]

@cmsbuild please test

[cmsbuild]

Pull request #39169 was updated. @epalencia, @clacaputo, @cmsbuild, @rekovic, @jpata, @mandrenguyen, @cecilecaillol can you please check and sign again.

[mandrenguyen]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9e45d3/27182/summary.html
COMMIT: 833e92c
CMSSW: CMSSW_12_6_X_2022-08-29-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39169/27182/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3696018
• DQMHistoTests: Total failures: 17
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3695979
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+reconstruction
I verified locally that extra collection is produced and that its size is tiny
Since L1 had previously signed, I think you can ahead and prepare the 12_5 and 12_4 backports

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1