-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Geometry_cff with GeometryDB_cff in DPGAnalysis #39167
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39167/31757
|
A new Pull Request was created by @jeongeun (JeongEun Lee) for master. It involves the following packages:
@cmsbuild, @bbilin, @kskovpen, @jordan-martins can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-40aaf4/27330/summary.html Comparison SummarySummary:
|
@cms-sw/pdmv-l2 |
+pdmv |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
please test
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-40aaf4/29335/summary.html Comparison SummarySummary:
|
+1
|
Surely not used, but we're trying to get rid of all mentions of Geometry_cff that were raised in the issue in the PR description. This is the last one in the reco packages. |
PR description:
Review on the Reco part of #31113
process.load("Configuration.StandardSequences.Geometry_cff")
was outdated #8810
It should be replaced with
process.load("Configuration.StandardSequences.GeometryDB_cff")
In this PR, DPGAnalysis configuration files (11 files) are fixed.
Please inform us if there is any obsolete configurations in this PR. Then I will remove.
PR validation:
Tested in CMSSW_12_5_X, the basic test all passed in the CMSSW PR instructions