Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Geometry_cff with GeometryDB_cff in DPGAnalysis #39167

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

jeongeun
Copy link
Contributor

PR description:
Review on the Reco part of #31113

process.load("Configuration.StandardSequences.Geometry_cff")
was outdated #8810
It should be replaced with
process.load("Configuration.StandardSequences.GeometryDB_cff")

In this PR, DPGAnalysis configuration files (11 files) are fixed.

        modified:   DPGAnalysis/Skims/python/CSCSkim_BFieldStudies_MC_ToscaMap090322_cfg.py
        modified:   DPGAnalysis/Skims/python/CSCSkim_BFieldStudies_ToscaMap090322_cfg.py
        modified:   DPGAnalysis/Skims/python/DoubleMuon_cfg.py
        modified:   DPGAnalysis/Skims/python/PointingDoubleMultiSkim_cfg.py
        modified:   DPGAnalysis/Skims/python/RPCNoise_example.py
        modified:   DPGAnalysis/Skims/python/SuperPointing_MC_ToscaMap090322_cfg.py
        modified:   DPGAnalysis/Skims/python/SuperPointing_ToscaMap090322_cfg.py
        modified:   DPGAnalysis/Skims/python/SuperPointing_and_pixcluster_cfg.py
        modified:   DPGAnalysis/Skims/python/TrackerPointing_MC_ToscaMap090322_cfg.py
        modified:   DPGAnalysis/Skims/python/TrackerPointing_ToscaMap090322_cfg.py
        modified:   DPGAnalysis/Skims/python/filterRecHits_cfg.py

Please inform us if there is any obsolete configurations in this PR. Then I will remove.

PR validation:

Tested in CMSSW_12_5_X, the basic test all passed in the CMSSW PR instructions

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39167/31757

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

  • DPGAnalysis/Skims (pdmv)

@cmsbuild, @bbilin, @kskovpen, @jordan-martins can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@smuzaffar smuzaffar modified the milestones: CMSSW_12_5_X, CMSSW_12_6_X Aug 28, 2022
@perrotta
Copy link
Contributor

perrotta commented Sep 5, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-40aaf4/27330/summary.html
COMMIT: 11f126e
CMSSW: CMSSW_12_6_X_2022-09-04-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39167/27330/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3618210
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3618177
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

@cms-sw/pdmv-l2
Perhaps you can sign?

@kskovpen
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

please test

  • Tests are several months old, needs a refresh.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-40aaf4/29335/summary.html
COMMIT: 11f126e
CMSSW: CMSSW_13_0_X_2022-11-29-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39167/29335/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3421159
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3421128
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

  • Quite likely unused configs, but ok...

@cmsbuild cmsbuild merged commit c9ca58d into cms-sw:master Nov 30, 2022
@mandrenguyen
Copy link
Contributor

+1

* Quite likely unused configs, but ok...

Surely not used, but we're trying to get rid of all mentions of Geometry_cff that were raised in the issue in the PR description. This is the last one in the reco packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants