Updates in TOP-HLT DQM : Deepjet HLT path monitoring & flag to enable/disable production of 2d histos

[ckoraka]

PR description:

This PR implements a cleanup of the Top PAG HLT Offline DQM code. Changes were made in certain files under DQMOffline/Trigger:
plugins/TopMonitor.cc
python/TopMonitor_cfi.py
python/TopMonitoring_Client_cff.py
python/TopMonitoring_cff.py

Changes :

• A flag to enable and disable the creation of 2D DQM plots was added (enable2DPlots) and was set to False.
• Added monitoring of the following HLT paths :
  1. HLT_PFHT400_SixPFJet32_DoublePFBTagDeepJet_2p94_v
  2. HLT_PFHT450_SixPFJet36_PFBTagDeepJet_1p59_v
     As a result, two additional sub-folders are expected to be produced:
     HLT/TOP/FullyHadronic/DoubleBTagDeepJet
     HLT/TOP/FullyHadronic/SingleBTagDeepJet
     Note : The deepCSV tagger is used for the selection of offline b-tagged jets since the deepjet b-tag handle is not available at RECO level. The compatibility of the trigger efficiency derived when selecting offline b-tagged jets with the deepjet vs the deepcsv tagger can be seen in slide 6 of this presentation. In the future we could consider calculating the deep-jet outputs of the offline jets on-the-fly.

No changes are expected in any of the previously produced histograms (sub-folders under HLT/TOP/*).

PR validation:

Tested with runTheMatrix.py -l 11634.0

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a back-port, and no back-port of this is planned.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39158/31739

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39158/31739/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39158/31739/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39158/31743

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @ckoraka for master.

It involves the following packages:

• DQMOffline/Trigger (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@HuguesBrun, @mtosi, @Fedespring, @missirol, @sscruz, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[emanueleusai]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8f0de/27034/summary.html
COMMIT: e8cb793
CMSSW: CMSSW_12_5_X_2022-08-23-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39158/27034/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3680454
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 125
• DQMHistoTests: Total successes: 3680294
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 20556.961 KiB( 50 files compared)
• DQMHistoSizes: changed ( 1000.0,... ): 2739.186 KiB HLT/HIG
• DQMHistoSizes: changed ( 1000.0,... ): 1894.660 KiB HLT/SUSY
• DQMHistoSizes: changed ( 1000.0,... ): 1322.936 KiB HLT/BTV
• DQMHistoSizes: changed ( 11634.0,... ): 518.483 KiB HLT/TOP
• DQMHistoSizes: changed ( 11634.0,... ): -99.612 KiB HLT/SUSY
• DQMHistoSizes: changed ( 11634.0,... ): -73.512 KiB HLT/BTV
• DQMHistoSizes: changed ( 11634.0,... ): -7.188 KiB HLT/B2G
• DQMHistoSizes: changed ( 11634.0,... ): 2.619 KiB HLT/HIG
• DQMHistoSizes: changed ( 139.001 ): 2933.004 KiB HLT/HIG
• DQMHistoSizes: changed ( 139.001 ): 1911.793 KiB HLT/SUSY
• DQMHistoSizes: changed ( 139.001 ): ...
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[emanueleusai]

@ckoraka there are many changes in the DQMHisto HLT subfolders outside of TOP:
DQMHistoSizes: changed ( 1000.0,... ): 2739.186 KiB HLT/HIG
DQMHistoSizes: changed ( 1000.0,... ): 1894.660 KiB HLT/SUSY
DQMHistoSizes: changed ( 1000.0,... ): 1322.936 KiB HLT/BTV
DQMHistoSizes: changed ( 11634.0,... ): 518.483 KiB HLT/TOP
DQMHistoSizes: changed ( 11634.0,... ): -99.612 KiB HLT/SUSY
DQMHistoSizes: changed ( 11634.0,... ): -73.512 KiB HLT/BTV
DQMHistoSizes: changed ( 11634.0,... ): -7.188 KiB HLT/B2G
DQMHistoSizes: changed ( 11634.0,... ): 2.619 KiB HLT/HIG
DQMHistoSizes: changed ( 139.001 ): 2933.004 KiB HLT/HIG
DQMHistoSizes: changed ( 139.001 ): 1911.793 KiB HLT/SUSY
In some cases adding, in some other removing plots

It looks like this stems from the fact that the hltTOPmonitoring module (TopMonitor DQMEDAnalyzer) is used in many other HLT DQM PAG/POG modules, see:
https://github.com/cms-sw/cmssw/search?q=hltTOPmonitoring

This means your changes reach far beyond the TOP group: is this expected/understood? has this been discussed with the other PAG/POG HLT contacts?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39158/31798

• This PR adds an extra 36KB to repository

[cmsbuild]

Pull request #39158 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

[ckoraka]

Hi @emanueleusai. Hmm no these additional changes were not expected. I think I have located the culprit and I will be fixing it now :
https://github.com/cms-sw/cmssw/pull/39158/files#diff-eb25272f2c9ac537f19b36b9bbf4e77f6cf4a9187d2e3cbbefe9306c0dc9a14aR1389

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39158/31810

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #39158 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.