exclude HLT-PNET DQM from HIon workflows #39051
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39051/31544
|
|
A new Pull Request was created by @missirol (Marino Missiroli) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-575b48/26797/summary.html Comparison SummarySummary:
|
|
@cms-sw/dqm-l2 , please have a look at this PR. It fixes HLT tests that are currently failing in IBs. |
| "eff_electron_eta 'Efficiency vs #eta(ele); #eta(ele); efficiency' electron_eta_numerator electron_eta_denominator", | ||
| "eff_dilepton_pt 'Efficiency vs p_{T}(ll); p_{T}(ll); efficiency' dilepton_pt_numerator dilepton_pt_denominator", | ||
| "eff_dilepton_mass 'Efficiency vs m(ll); m(ll); efficiency' dilepton_mass_numerator dilepton_mass_denominator", | ||
| "eff_ht 'Efficiency vs H_{T}; H_{T}; efficiency' ht_numerator ht_denominator", |
There was a problem hiding this comment.
This line in master is currently missing a comma, and I guess this fix might lead to a few differences in PR outputs.
| "eff_muon_eta 'Efficiency vs #eta(#mu); #eta(#mu); efficiency' muon_eta_numerator muon_eta_denominator", | ||
| "eff_electron_pt 'Efficiency vs p_{T}(ele); p_{T}(ele); efficiency' electron_pt_numerator electron_pt_denominator", | ||
| "eff_electron_eta 'Efficiency vs #eta(ele); #eta(ele); efficiency' electron_eta_numerator electron_eta_denominator", | ||
| "eff_ht 'Efficiency vs H_{T}; H_{T}; efficiency' ht_numerator ht_denominator", |
There was a problem hiding this comment.
This line in master is currently missing a comma, and I guess this fix might lead to a few differences in PR outputs.
|
@cms-sw/dqm-l2 , kind ping to review this PR. It is needed to fix some of the HLT tests running in IBs. |
|
Another ping to @cms-sw/dqm-l2 to please review this PR. The developer of the original PR is okay with this fix, see #38748 (comment). This is needed asap to fix the HLT tests that are failing in IBs. |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
After the integration of #38748, the HLT-Validation tests in IBs are failing in
12_5_X.Afaiu, the issue is that the DQM modules added in #38748 can trigger the execution of modules from the offline reconstruction, to infer the PNET score of offline jets. Since some of those offline-jet collections aren't available in HIon wfs, this leads to exceptions due to missing products in such wfs of the HLT-Validation tests.
This PR provides a fix. If needed, a better solution will be provided by experts in the near future (see discussion at the end of #38748).
Some of the config files introduced in #38748 are re-organised in
cfis andcffs for clarity.No changes are expected in the outputs of PR tests, modulo #39051 (comment).
PR validation:
TSG tests.
If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A