Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.4.X] implement event consumes in MuScleFit #39030

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 11, 2022

backport of #39029

PR description:

Title says it all.

PR validation:

Run with this branch the configuration posted at #38958 (comment) (for convenience also available here) successfully.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #39029 to CMSSW_12_4_X, needed for tracker alignment purposes

@mmusich
Copy link
Contributor Author

mmusich commented Aug 11, 2022

type trk,bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 11, 2022

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_4_X.

It involves the following packages:

  • MuonAnalysis/MomentumScaleCalibration (analysis)

@cmsbuild can you please review it and eventually sign? Thanks.
@rchatter, @bellan, @argiro, @thomreis, @simonepigazzini this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 11, 2022

urgent

  • needed for data-taking validation purposes

@mmusich
Copy link
Contributor Author

mmusich commented Aug 11, 2022

assign alca

@cmsbuild
Copy link
Contributor

New categories assigned: alca

@yuanchao,@francescobrivio,@malbouis,@saumyaphor4252,@tvami,@ChrisMisan you have been requested to review this Pull request/Issue and eventually sign? Thanks

@mmusich mmusich force-pushed the muscleFitConsumes_12_4_X branch from 79eb2fe to c6428f2 Compare August 11, 2022 13:17
@cmsbuild
Copy link
Contributor

Pull request #39030 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Aug 11, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24f387/26760/summary.html
COMMIT: c6428f2
CMSSW: CMSSW_12_4_X_2022-08-11-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39030/26760/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3677242
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3677218
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Aug 11, 2022

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 12, 2022

+1

@cmsbuild cmsbuild merged commit a903d39 into cms-sw:CMSSW_12_4_X Aug 12, 2022
@mmusich mmusich deleted the muscleFitConsumes_12_4_X branch August 12, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants