Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miscellaneous updates to SiPixel Lorentz Angle Calibration harvesting #38996

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 8, 2022

PR description:

Miscellaneous updates to SiPixel Lorentz Angle Calibration harvesting:

PR validation:

cmssw compiles, needs more private testing.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Perhaps to be backported to the production release (12.4.X)

@mmusich
Copy link
Contributor Author

mmusich commented Aug 8, 2022

@wweiphy @tsusa FYI

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38996/31465

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2022

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • CalibTracker/SiPixelLorentzAngle (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@tocheng, @OzAmram, @ferencek, @mmusich, @dkotlins, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 8, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b23764/26708/summary.html
COMMIT: 404b8de
CMSSW: CMSSW_12_5_X_2022-08-08-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38996/26708/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3691612
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3691576
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38996/31485

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

Pull request #38996 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

@tvami
Copy link
Contributor

tvami commented Aug 10, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b23764/26740/summary.html
COMMIT: d3d87a8
CMSSW: CMSSW_12_5_X_2022-08-10-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38996/26740/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 138.4138.4_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3/step2_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3.log
  • 140.109140.109_RunEGamma2022B+RunEGamma2022B+HLTRUN3+RECONANORUN3+SKIMEGAMMARUN3/step2_RunEGamma2022B+RunEGamma2022B+HLTRUN3+RECONANORUN3+SKIMEGAMMARUN3.log
  • 140.57140.57_RunHI2018Reduced+RunHI2018Reduced+RECOHID18+HARVESTDHI18/step2_RunHI2018Reduced+RunHI2018Reduced+RECOHID18+HARVESTDHI18.log
Expand to see more relval errors ...

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3692476
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3692440
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38996/31567

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

Pull request #38996 was updated. @malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

@tvami
Copy link
Contributor

tvami commented Aug 15, 2022

@mmusich shall we test this? or something more is coming?

@mmusich
Copy link
Contributor Author

mmusich commented Aug 15, 2022

or something more is coming?

I am not planning more updates, unless there are more comments.

@tvami
Copy link
Contributor

tvami commented Aug 15, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b23764/26828/summary.html
COMMIT: 490e6ae
CMSSW: CMSSW_12_5_X_2022-08-15-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38996/26828/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3692476
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3692440
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Aug 15, 2022

+alca

  • tests pass

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 16, 2022

+1

@mmusich
Copy link
Contributor Author

mmusich commented Aug 16, 2022

@tvami

can it be due to this?

yes, it's actually a commit I had not pushed :/
Here it's the fix: #39083

@mmusich mmusich deleted the miscellaneousUpdatesToPixelLAHarvester branch August 16, 2022 15:42
cmsbuild added a commit that referenced this pull request Aug 21, 2022
…rverster

Fix for `SiPixelLorentzAnglePCLHarvester` after #38996
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants