Handle pixel modules with all invalid pixels [12.4.x]

[fwyzard]

PR description:

Deal with the the case where all pixels in a module are invalid or duplicate.

PR validation:

Testes over data from run 356998: the events which caused crashes with CMSSW_12_4_5_patch1 are being processed without errors with these changes.

If this PR is a backport please specify the original PR and why you need to backport that PR.

Backport of #38988 for data taking.

[fwyzard]

backport #38988

[fwyzard]

type bugfix

[fwyzard]

urgent

[fwyzard]

enable gpu

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_12_4_X.

It involves the following packages:

• RecoLocalTracker/SiPixelClusterizer (reconstruction)

@jpata, @cmsbuild, @clacaputo can you please review it and eventually sign? Thanks.
@mtosi, @VourMa, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @OzAmram, @ferencek, @dkotlins, @gpetruc, @mmusich, @threus, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Handle pixel modules with all invalid pixels #38988

[fwyzard]

please test

[fwyzard]

please test

[cmsbuild]

Pull request #38989 was updated. @jpata, @clacaputo can you please check and sign again.

[cmsbuild]

Pull request #38989 was updated. @jpata, @cmsbuild, @clacaputo can you please check and sign again.

[cmsbuild]

Pull request #38989 was updated. @jpata, @cmsbuild, @clacaputo can you please check and sign again.

[fwyzard]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4ba025/26696/summary.html
COMMIT: 7ca6d96
CMSSW: CMSSW_12_4_X_2022-08-07-2300/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38989/26696/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19876
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 19868
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: found differences in 2 / 3 workflows

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3677242
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3677206
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[jpata]

+reconstruction

• direct backport of Handle pixel modules with all invalid pixels #38988
• bugfix for GPU (validated by the author)
• no reco changes in standard tests

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[jordan-martins]

@cms-sw/orp-l2 can we have this included in a new patch release to be deployed at HLT, please?

[tyjyang]

confirming with Jordan, dear release team @perrotta, @dpiparo, @qliphy, @rappoccio, we need to have a new patch release for this.

-- Justin as ORM

[qliphy]

+1
requested urgently to be included in a patched 12_4 release to be deployed at HLT
#38989 (comment)