-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing #include to EdmProvDump.cc #38889
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38889/31320
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages:
@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test for el8_amd64_gcc11 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
@aandvalenzuela The tests seem to be stuck. Is it just because the test infrastructure is busy, or is there something else going on? |
@makortel It seems everything went fine, but the comparison with the baseline was not triggered: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c3af81/26518/summary.html |
Thanks! |
I have triggered it and it seems it is running fine now. This job normally lasts |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c3af81/26518/summary.html Comparison SummarySummary:
|
+1 |
PR description:
#38858 broke the
al8_amd64_gcc11
build by missing the#include <optional>
(see log. This PR adds that.Resolves #38892
PR validation:
Code compiles on
el8_amd64_gcc11
architecture.