Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing #include to EdmProvDump.cc #38889

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Jul 28, 2022

PR description:

#38858 broke the al8_amd64_gcc11 build by missing the #include <optional> (see log. This PR adds that.

Resolves #38892

PR validation:

Code compiles on el8_amd64_gcc11 architecture.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38889/31320

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

  • IOPool/Common (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test for el8_amd64_gcc11

@makortel
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@makortel
Copy link
Contributor Author

@aandvalenzuela The tests seem to be stuck. Is it just because the test infrastructure is busy, or is there something else going on?

@aandvalenzuela
Copy link
Contributor

@makortel It seems everything went fine, but the comparison with the baseline was not triggered: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c3af81/26518/summary.html
I am having a look in case I can retrigger it

@makortel
Copy link
Contributor Author

Thanks!

@aandvalenzuela
Copy link
Contributor

I have triggered it and it seems it is running fine now. This job normally lasts ~2.30h.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c3af81/26518/summary.html
COMMIT: 9160f64
CMSSW: CMSSW_12_5_X_2022-07-28-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38889/26518/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8809 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3668050
  • DQMHistoTests: Total failures: 17874
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3650154
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 210 log files, 47 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a1ee449 into cms-sw:master Jul 29, 2022
@makortel makortel deleted the edmProvDumpFixGcc11 branch July 29, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler errors and unit test failure in IOPool/Common for el9_x_gcc11
4 participants