[HGCAL geometry] Fix definition of 60degree sectors 0 and 1

[jbsauvan]

• Fix 60deg sector definition in the sector rotation utility (some wafers were wrongly assigned to sector 0 instead of sector 1).
• The function where this fix has been made is not used anywhere yet, so no change is expected in the output.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38861/31273

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @jbsauvan (Jean-Baptiste Sauvan) for master.

It involves the following packages:

• Geometry/HGCalCommonData (geometry, upgrade)

@civanch, @Dr15Jones, @bsunanda, @makortel, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@trtomei, @bsunanda, @beaucero, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[perrotta]

@jbsauvan please edit the name to make clear that this PR relates to HGCal

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-483c75/26460/summary.html
COMMIT: a7cb997
CMSSW: CMSSW_12_5_X_2022-07-25-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38861/26460/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3667670
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3667634
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 210 log files, 47 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[srimanob]

type bug-fix

[srimanob]

+Upgrade

I don't see anything change in PR test, maybe because it is too small test or the change of the sector does not effect sim/reco results.

[jbsauvan]

Hello @srimanob
Actually the function where the change has been made is not used anywhere yet. So that makes sense that no changes can be seen.

[srimanob]

OK, Thanks for clarification @jbsauvan
Could you please add your statement on PR description? Thanks.

[jbsauvan]

@srimanob done

[bsunanda]

+geometry

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1