L1T DQM: Adding the uGT timing sequence back and updating the relevant algo list #38840

vukasinmilosevic · 2022-07-23T13:00:44Z

L1T DQM update:

Putting the uGT timing sequence back into the workflow
Updating relevant triggers to match the Run 3 menu (L1Menu_Collisions2022_v1_0_1)

…on L1Menu_Collisions2022_v1_0_1

cmsbuild · 2022-07-23T13:06:06Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38840/31228

This PR adds an extra 16KB to repository

cmsbuild · 2022-07-23T13:06:24Z

A new Pull Request was created by @vukasinmilosevic (Vukasin Milosevic) for master.

It involves the following packages:

DQM/L1TMonitor (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

qliphy · 2022-07-25T00:52:10Z

please test

cmsbuild · 2022-07-25T05:25:45Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-afe092/26426/summary.html
COMMIT: 365f375
CMSSW: CMSSW_12_5_X_2022-07-24-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38840/26426/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 18 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3667670
DQMHistoTests: Total failures: 14
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3667634
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 2932.0660000000003 KiB( 50 files compared)
DQMHistoSizes: changed ( 10024.0,... ): 145.340 KiB L1T/L1TStage2uGT
DQMHistoSizes: changed ( 10824.0,... ): 147.637 KiB L1T/L1TStage2uGT
DQMHistoSizes: changed ( 1306.0,... ): 143.535 KiB L1T/L1TStage2uGT
DQMHistoSizes: changed ( 140.56 ): 146.160 KiB L1T/L1TStage2uGT
Checked 210 log files, 47 edm output root files, 51 DQM output files
TriggerResults: no differences found

emanueleusai · 2022-07-28T03:36:44Z

type l1t

emanueleusai · 2022-07-28T03:37:21Z

+1

cmsbuild · 2022-07-28T03:37:27Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-07-28T05:23:58Z

This PR is adding quite several warning lines in the logs of several workflows, for example wf1306.0:

%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_FirstCollisionInTrain" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_LastCollisionInTrain" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleMu22_BMTF" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleMu22_OMTF" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleMu22_EMTF" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleIsoEG28er1p5" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleIsoEG32er2p5" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleEG40er2p5" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleEG60" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleTau120er2p1" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_ETMHF130" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_HTT360er" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_ETT2000" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_FirstCollisionInTrain" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_LastCollisionInTrain" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleMu0_BMTF" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleMu0_OMTF" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleMu0_EMTF" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleEG10er2p5" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleEG15er2p5" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleEG26er2p5" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleLooseIsoEG28er1p5" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleJet60er2p5" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_SingleJet60_FWD3p0" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_ETMHF100" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_HTT120er" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TStage2uGTTiming:   L1TStage2uGTTiming:l1tStage2uGTTiming@streamBeginRun 25-Jul-2022 04:05:33 CEST  Run: 1 Stream: 0
Algo "L1_ETT1200" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG

Please add the new modules only when needed/available, e.g. by using relevant modifiers

perrotta · 2022-07-28T05:27:44Z

By the way, even the baseline shows for the same wf the following warning messages

%MSG
%MSG-w L1TObjectsTiming:  L1TObjectsTiming:l1tObjectsTiming@streamBeginRun  25-Jul-2022 03:32:54 CEST Run: 1 Stream: 0
Algo "L1_FirstCollisionInTrain" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG
%MSG-w L1TObjectsTiming:  L1TObjectsTiming:l1tObjectsTiming@streamBeginRun  25-Jul-2022 03:32:54 CEST Run: 1 Stream: 0
Algo "L1_LastCollisionInTrain" not found in the trigger menu L1Menu_Collisions2016_v6r5. Could not retrieve algo bit number.
%MSG

I imagine there are other modules in that sequence that should also get protected behind relevant modifiers

qliphy · 2022-08-09T01:12:20Z

ping @vukasinmilosevic

vukasinmilosevic · 2022-08-09T20:15:00Z

Hi @qliphy, @perrotta, apologies for the delay in response. Ok, this seems like it is complaining due to the L1 menu for 2016 lacking the triggers used in 17/18 and Run 3.

I can add the protections, but could you please point me to the instructions on how to do so (apologies if this is a basic question)?

perrotta · 2022-08-16T04:58:28Z

Hi @qliphy, @perrotta, apologies for the delay in response. Ok, this seems like it is complaining due to the L1 menu for 2016 lacking the triggers used in 17/18 and Run 3.

I can add the protections, but could you please point me to the instructions on how to do so (apologies if this is a basic question)?

You can configure for the different data taking periods using the corresponding eras, see e..g. https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideCmsDriverEras

cmsbuild · 2022-08-24T18:05:12Z

Pull request #38840 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

perrotta · 2022-08-24T20:01:49Z

DQM/L1TMonitor/python/L1TStage2uGT_cff.py

+from Configuration.StandardSequences.Eras import eras
+
+eras.run3_common.toReplaceWith(l1tStage2uGTOnlineDQMSeq, _run3_l1tStage2uGTOnlineDQMSeq)


Thank you @vukasinmilosevic , it should work
Looking at the examples around, the correct way to code it is

Suggested change

from Configuration.StandardSequences.Eras import eras

eras.run3_common.toReplaceWith(l1tStage2uGTOnlineDQMSeq, _run3_l1tStage2uGTOnlineDQMSeq)

from Configuration.Eras.Modifier_run3_common_cff import run3_common

run3_common.toReplaceWith(l1tStage2uGTOnlineDQMSeq, _run3_l1tStage2uGTOnlineDQMSeq)

perrotta · 2022-08-24T20:02:42Z

DQM/L1TMonitor/python/L1TStage2uGT_cff.py

@@ -28,7 +28,14 @@
 # sequences
 l1tStage2uGTOnlineDQMSeq = cms.Sequence(
    l1tStage2uGT +
-    # l1tStage2uGTTiming +
+#    l1tStage2uGTTiming +


This can be removed, you can now compare with the other sequence to identify what's missing

Suggested change

# l1tStage2uGTTiming +

Thank you @perrotta! I've tested the suggested changes with a Run 3 input file and the timing plots are there as well.

cmsbuild · 2022-08-25T11:07:23Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38840/31794

This PR adds an extra 16KB to repository

cmsbuild · 2022-08-25T11:07:47Z

Pull request #38840 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

perrotta · 2022-08-25T11:58:13Z

please test

cmsbuild · 2022-08-25T15:48:28Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-afe092/27088/summary.html
COMMIT: 6b13b2c
CMSSW: CMSSW_12_5_X_2022-08-25-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38840/27088/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3693084
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3693060
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1476.3699999999997 KiB( 50 files compared)
DQMHistoSizes: changed ( 11634.0,... ): 147.637 KiB L1T/L1TStage2uGT
Checked 212 log files, 49 edm output root files, 51 DQM output files
TriggerResults: no differences found

emanueleusai · 2022-08-29T18:31:32Z

+1

cmsbuild · 2022-08-29T18:31:56Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-08-29T19:18:01Z

+1

Adding the uGT timing sequence back and updating the algo list based …

365f375

…on L1Menu_Collisions2022_v1_0_1

cmsbuild added this to the CMSSW_12_5_X milestone Jul 23, 2022

cmsbuild added code-checks-pending dqm-pending orp-pending pending-signatures tests-pending labels Jul 23, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 23, 2022

cmsbuild added tests-started and removed tests-pending labels Jul 25, 2022

cmsbuild added tests-approved and removed tests-started labels Jul 25, 2022

cmsbuild added the l1t label Jul 28, 2022

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jul 28, 2022

perrotta reviewed Aug 24, 2022

View reviewed changes

Fixing the imports based on the example

6b13b2c

cmsbuild added code-checks-pending and removed code-checks-approved labels Aug 25, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 25, 2022

cmsbuild added tests-started and removed tests-pending labels Aug 25, 2022

cmsbuild added tests-approved and removed tests-started labels Aug 25, 2022

smuzaffar modified the milestones: CMSSW_12_5_X, CMSSW_12_6_X Aug 28, 2022

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Aug 29, 2022

cmsbuild added orp-approved and removed orp-pending labels Aug 29, 2022

cmsbuild merged commit e3427f3 into cms-sw:master Aug 29, 2022

cmsbuild mentioned this pull request Aug 31, 2022

[L1T] fix asan runtime errors in DTTrigger Phase-2 #39263

Merged

vukasinmilosevic mentioned this pull request Oct 14, 2022

[12_4_X] L1T DQM: Adding the uGT timing sequence back and updating the relevant algo list - backport #39734

Merged

vukasinmilosevic mentioned this pull request Oct 31, 2022

[12_5_X] L1T DQM: Adding the uGT timing sequence back and updating the relevant algo list - backport #39935

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

L1T DQM: Adding the uGT timing sequence back and updating the relevant algo list #38840

L1T DQM: Adding the uGT timing sequence back and updating the relevant algo list #38840

vukasinmilosevic commented Jul 23, 2022

cmsbuild commented Jul 23, 2022

cmsbuild commented Jul 23, 2022

qliphy commented Jul 25, 2022

cmsbuild commented Jul 25, 2022

emanueleusai commented Jul 28, 2022

emanueleusai commented Jul 28, 2022

cmsbuild commented Jul 28, 2022

perrotta commented Jul 28, 2022

perrotta commented Jul 28, 2022

qliphy commented Aug 9, 2022

vukasinmilosevic commented Aug 9, 2022

perrotta commented Aug 16, 2022

cmsbuild commented Aug 24, 2022

perrotta Aug 24, 2022

perrotta Aug 24, 2022

vukasinmilosevic Aug 25, 2022

cmsbuild commented Aug 25, 2022

cmsbuild commented Aug 25, 2022

perrotta commented Aug 25, 2022

cmsbuild commented Aug 25, 2022

emanueleusai commented Aug 29, 2022

cmsbuild commented Aug 29, 2022

perrotta commented Aug 29, 2022

		from Configuration.StandardSequences.Eras import eras

		eras.run3_common.toReplaceWith(l1tStage2uGTOnlineDQMSeq, _run3_l1tStage2uGTOnlineDQMSeq)

L1T DQM: Adding the uGT timing sequence back and updating the relevant algo list #38840

L1T DQM: Adding the uGT timing sequence back and updating the relevant algo list #38840

Conversation

vukasinmilosevic commented Jul 23, 2022

cmsbuild commented Jul 23, 2022

cmsbuild commented Jul 23, 2022

qliphy commented Jul 25, 2022

cmsbuild commented Jul 25, 2022

Comparison Summary

emanueleusai commented Jul 28, 2022

emanueleusai commented Jul 28, 2022

cmsbuild commented Jul 28, 2022

perrotta commented Jul 28, 2022

perrotta commented Jul 28, 2022

qliphy commented Aug 9, 2022

vukasinmilosevic commented Aug 9, 2022

perrotta commented Aug 16, 2022

cmsbuild commented Aug 24, 2022

perrotta Aug 24, 2022

Choose a reason for hiding this comment

perrotta Aug 24, 2022

Choose a reason for hiding this comment

vukasinmilosevic Aug 25, 2022

Choose a reason for hiding this comment

cmsbuild commented Aug 25, 2022

cmsbuild commented Aug 25, 2022

perrotta commented Aug 25, 2022

cmsbuild commented Aug 25, 2022

Comparison Summary

emanueleusai commented Aug 29, 2022

cmsbuild commented Aug 29, 2022

perrotta commented Aug 29, 2022