Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GEM alignment in all Run3 GTs #38832

Merged
merged 1 commit into from
Jul 23, 2022
Merged

Add GEM alignment in all Run3 GTs #38832

merged 1 commit into from
Jul 23, 2022

Conversation

francescobrivio
Copy link
Contributor

PR description:

Following the discussion in #38760 (comment) this PR updates mainly the GEMAlignemnt tags in all Run 3 GTs (both online and MC).
Further minor updates:

  • In order to be consistent with the new GEMAlignment tags (and with the GEM geometry already in use in HLT/Express/Prompt), the data and data_relval GTs have also been updated with the latest GEMRECO_Geometry tag (from v2 to v3)
  • new DroboxMetaData tag for the Express and Prompt frozen GTs and in the data and data_relval GTs (CMSTalk post)

The new GEM tags are:
GEMAlignment_hlt_v2
GEMAlignment_express_v2
GEMAlignment_prompt_v2
GEMAlignment_v2
GEMAlignment_MC_v1
GEMAlignment_ideal_MC_v1

GEMAlignmentErrorExtended_6x6_hlt_v2
GEMAlignmentErrorExtended_6x6_express_v2
GEMAlignmentErrorExtended_6x6_prompt_v2
GEMAlignmentErrorExtended_6x6_v2
GEMAlignmentErrorExtended_6x6_MC_v1
GEMAlignmentErrorExtended_6x6_ideal_MC_v1

The GEMRECO geometry tag is:
GEMRECO_Geometry_v3_hlt

The new DMD tag is:
DropBoxMetadata_v8_express

GT Diffs:

PR validation:

Tested with:
runTheMatrix.py -l 139.001,138.4,138.5,12034.0,11634.0,7.23,159.0,12434.0,12834.0 --ibeos -j 16

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Forward-port of #38693

@cmsbuild cmsbuild added this to the CMSSW_12_5_X milestone Jul 22, 2022
@francescobrivio
Copy link
Contributor Author

test parameters:

  • workflows = 12034.0,11634.0,7.23,159.0,12434.0,12834.0

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38832/31210

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@malbouis, @yuanchao, @cmsbuild, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@francescobrivio francescobrivio mentioned this pull request Jul 22, 2022
Merged
@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@tvami
Copy link
Contributor

tvami commented Jul 22, 2022

type gem

@cmsbuild cmsbuild added the gem label Jul 22, 2022
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-96c077/26396/summary.html
COMMIT: 91d52e9
CMSSW: CMSSW_12_5_X_2022-07-21-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38832/26396/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-96c077/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-96c077/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 55
  • DQMHistoTests: Total histograms compared: 4171910
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4171880
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 54 files compared)
  • Checked 229 log files, 47 edm output root files, 55 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Jul 23, 2022

+alca

  • diffs in MsgLogger and MTD only

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@tvami
Copy link
Contributor

tvami commented Jul 23, 2022

urgent

  • we'd like this to be in the next 12_5_X pre release

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 20cff26 into cms-sw:master Jul 23, 2022
@francescobrivio francescobrivio deleted the alca-newGEMalignment branch July 29, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved code-checks-approved fully-signed gem orp-approved tests-approved urgent
Projects
None yet
Milestone
CMSSW_12_5_X
Development

Successfully merging this pull request may close these issues.
4 participants
@francescobrivio @cmsbuild @tvami @perrotta