Allowing EGM IDs to run in Mini with Nano workflows

[Sam-Harper]

PR description:

This PR addresses the issue where MiniAOD and Nano can not run in the same job when using EGM IDs in NANO as identified in #38690

The reason for this is simple:

EGM IDs use valuemaps
Values are keyed to specific collection of objects
Nano uses selectedPatPhotons
EGM IDs are produced with reducedEGamma:reducedPhotons which is needed to embed the IDs in the selectedPatPhotons

The solution in this PR is to allow the offending modules to also get the ancestor collections and thus be able to convert their pointer to a pointer in the equivalent photon (or electron) in the collection used for the value maps. To map one photon / electron to another, their supercluster seed ID is used.

A better solution would be that nano rather than reinventing the wheel, retrieves the objects from from the pat::Electrons of mini directly and doesnt mess around with value maps, this is how EGM intended this to be used. But that is out side the scope of this PR.

PR validation:

when testing the workflow runTheMatrix.py -l 11634.0, it now works and ids are being produced as expected.

[Sam-Harper]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38810/31177

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/python/photons_cff.py modified in PR(s): re-enable photons for run3 in nanoAOD #38690

[cmsbuild]

A new Pull Request was created by @Sam-Harper (Sam Harper) for master.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)
• PhysicsTools/PatAlgos (reconstruction)

@jpata, @mariadalfonso, @gouskos, @fgolf, @clacaputo can you please review it and eventually sign? Thanks.
@AlexDeMoor, @rappoccio, @gouskos, @jdolen, @swertz, @JyothsnaKomaragiri, @ahinzmann, @schoef, @emilbols, @jdamgov, @mbluj, @nhanvtran, @gkasieczka, @hatakeyamak, @gpetruc, @azotz, @mariadalfonso, @demuller, @andrzejnovak, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mariadalfonso]

please test

[mariadalfonso]

started the test let's see if all smooth

note that the electron are in the identical situation and we will need to reactivate the IDs also here
https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/python/electrons_cff.py#L544-L575

[Sam-Harper]

started the test let's see if all smooth

well you reset the tests I was running :D

note that the electron are in the identical situation and we will need to reactivate the IDs also here

It all works with that, that change will would be in already but there was a merge conflict so decided for the quiet life to not include that part in this PR

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a9b07b/26368/summary.html
COMMIT: 76bdc24
CMSSW: CMSSW_12_5_X_2022-07-21-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38810/26368/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a9b07b/13234.0_TTbar_14TeV+2021FS+TTbar_14TeV_TuneCP5_FastSimRun3+HARVESTFastRun3
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a9b07b/13434.0_TTbar_14TeV+2021FSPU+TTbar_14TeV_TuneCP5_FastSimRun3PU+HARVESTFastRun3PU

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3706484
• DQMHistoTests: Total failures: 44
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3706418
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 210 log files, 47 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[mariadalfonso]

ID on Run3 correctly filled now

both workflow with mini and nano in two step or mini+nano in one step works

[mariadalfonso]

+xpog

[swagata87]

thank you @Sam-Harper

[mariadalfonso]

@jpata @clacaputo

we will need your signature

[clacaputo]

+reconstruction

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Photon IDs are filled now