-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete orphan scripts accessing Geometry_cff / GeometryDB_cff #38782
Conversation
@yuanchao, CMSSW_12_5_X branch is closed for direct updates. cms-bot is going to move this PR to master branch. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38782/31129
|
A new Pull Request was created by @yuanchao (Yuan CHAO) for master. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
FYI @hyunyong |
@cmsbuild , please test |
type muon |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-34ff3c/26324/summary.html Comparison SummarySummary:
|
+alca
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Following up the migration of Geometry_cff to GeometryDB_cff (#35278), proper GlobalTag needs to be set in advance. As
contacted to the sub-system experts, out-of-date scripts that won't be fixed would be cleaned up.
PR validation:
delete out-dates script.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a back port and no back port expected. These scripts will be kept in old CMSSW versions.