Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run3-alca224 Make use of MessageLogger wherever possible in Calibration/IsolatedParticles and HcalIsolatedTrackReco packages and also extend the use of the macros #38780

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Run3-alca224 Make use of MessageLogger wherever possible in Calibration/IsolatedParticles and HcalIsolatedTrackReco packages and also extend the use of the macros #38780

merged 1 commit into from
Jul 21, 2022

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Jul 19, 2022 •
edited
Loading

PR description:

Make use of MessageLogger wherever possible in Calibration/IsolatedParticles and HcalIsolatedTrackReco packages. Several macros in IsolatedParticles are modified to extend their performances

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

@cmsbuild cmsbuild added this to the CMSSW_12_5_X milestone Jul 19, 2022
@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38780/31123

  • This PR adds an extra 64KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38780/31124

  • This PR adds an extra 76KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Calibration/HcalIsolatedTrackReco (alca)
  • Calibration/IsolatedParticles (alca)

@malbouis, @yuanchao, @cmsbuild, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Jul 19, 2022

@ChrisMisan I'll let you review this one, ok?

@ChrisMisan
Copy link
Contributor

type hcal

@cmsbuild cmsbuild added the hcal label Jul 19, 2022
@ChrisMisan
Copy link
Contributor

please test

@ChrisMisan
Copy link
Contributor

type performance-improvements

ChrisMisan
ChrisMisan reviewed Jul 19, 2022
View reviewed changes
Copy link
Contributor

@ChrisMisan ChrisMisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsunanda I am seeing a lot of changes under /macros, can you please change the title accordingly and also squash the commits?

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c7273/26319/summary.html
COMMIT: ef1e2ad
CMSSW: CMSSW_12_5_X_2022-07-18-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38780/26319/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3662417
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3662387
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@bsunanda bsunanda changed the title Run3-alca224 Make use of MessageLogger wherever possible in Calibration/IsolatedParticles and HcalIsolatedTrackReco packages Run3-alca224 Make use of MessageLogger wherever possible in Calibration/IsolatedParticles and HcalIsolatedTrackReco packages and also extend the use of the macros Jul 19, 2022
@ChrisMisan
Copy link
Contributor

@bsunanda Can you also squash the commits to one?

Make use of MessageLogger wherever possible in Calibration/IsolatedPa…
fe1c621 
…rticles and HcalIsolatedTrackReco packages

Code check
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38780/31168

  • This PR adds an extra 64KB to repository

@cmsbuild
Copy link
Contributor

Pull request #38780 was updated. @malbouis, @yuanchao, @cmsbuild, @francescobrivio, @ChrisMisan, @tvami can you please check and sign again.

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c7273/26359/summary.html
COMMIT: fe1c621
CMSSW: CMSSW_12_5_X_2022-07-20-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38780/26359/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-9c7273/13234.0_TTbar_14TeV+2021FS+TTbar_14TeV_TuneCP5_FastSimRun3+HARVESTFastRun3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-9c7273/13434.0_TTbar_14TeV+2021FSPU+TTbar_14TeV_TuneCP5_FastSimRun3PU+HARVESTFastRun3PU

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3706484
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3706454
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 210 log files, 47 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@ChrisMisan
Copy link
Contributor

+alca

  • no differences aside from msgLogger and MTD
  • PR in line with the description

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@ChrisMisan
Copy link
Contributor

There are several places where iterative loop can be changed to the range based one e.g.
https://github.com/cms-sw/cmssw/pull/38780/files#diff-90ca2a7c21ff99e833a07c9d5f1004a273f7fafd1217286eefb9bf5dbd2b645cL120
Maybe it's worth considering for the future improvements.

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d7e416c into cms-sw:master Jul 21, 2022
@cmsbuild cmsbuild mentioned this pull request Jul 21, 2022
Merged
@bsunanda bsunanda deleted the Run3-alca224 branch August 20, 2022 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisMisan ChrisMisan ChrisMisan left review comments

Assignees
No one assigned
Labels
alca-approved code-checks-approved fully-signed hcal orp-approved performance-improvements tests-approved
Projects
None yet
Milestone
CMSSW_12_5_X
Development

Successfully merging this pull request may close these issues.
5 participants
@bsunanda @cmsbuild @tvami @ChrisMisan @perrotta