Add default calibration product to PPS TDC PCL

[ChrisMisan]

PR description:

There was a possibility of crash in:

cmssw/RecoPPS/Local/src/CTPPSDiamondRecHitProducerAlgorithm.cc

Line 77 in 2a0aaba

ch_t_twc = calib_fct_->evaluate(std::vector<double>{tot}, ch_params);

if the calibration was not produced for a given channel. This fix adds the default 0 calibration product to the PCL.

PR validation:

Can be validated with relval 1041

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR should be backported to the 12_4_X

[ChrisMisan]

type ctpps, bug-fix

[ChrisMisan]

urgent

• backport is urgent

[ChrisMisan]

test parameters:

workflow = 1041

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38770/31097

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @ChrisMisan (Christopher) for master.

It involves the following packages:

• CalibPPS/TimingCalibration (alca)

@malbouis, @yuanchao, @cmsbuild, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@fabferro, @mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[ChrisMisan]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7d4e9/26291/summary.html
COMMIT: 8ac479a
CMSSW: CMSSW_12_5_X_2022-07-17-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38770/26291/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f7d4e9/1041.0_RunExpressPhy2017F+RunExpressPhy2017F+TIER0EXPPPSCAL+ALCASPLITPPSCAL+ALCAHARVDPPSCAL

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3654341
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3654317
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 45 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[malbouis]

+alca

• PR inline with description (fix needed for PPS Diamonds PCL)
• tests pass
• it is worth noting that since the payloads produced by this PCL workflow are not yet enabled to be used at Prompt Reco at the moment, there was no crash observed, but this fix is needed in order to enable the PCL tag at Prompt Reco.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1