Update cscvalidation for 12x

[ptcox]

PR description:

This PR updates RecoLocalMuon/CSCValidation to CMSSW 12_X compatibility,
This is a stand-alone package for analyzing CSC digis, rechits, and segments, in more or less detail. Historically it was used to prototype DQM code. More recently is was used to provide CSC expert diagnostic plots which are too resource-intensive for use in DQM, and run in an automated fashion via a complex python scripts. I have integrated various developments in the code used externally into the CMSSW version for consistency, as well as updating for 12_x compatibility

It is a final-user package, not used anywhere else in CMSSW.

It includes src files and test files, and a subdirectory macros containing various root-related files for producing nice plots from the root output file produced by running CSCValidation.

It does not enter in, or affect, any CMSSW workflows.
It does not depend on any other PRs.

PR validation:

I have tested this extensively in 12_3_6 and in 12_5_0_pre3, running on 12.5 TeV collisions data in Express FEVT, SingleMuon RAW, and the SingleMuon Zmu skim RAW.

I have run
git cms-checkdeps -a -A
scram b -j 8
scram b runtests
without issue,

I attempted to run runTheMatrix.py -l limited -i all --ibeos but after it had produced 20 subdirectories of output I ran out of disk space (they filled 10% of my quota which seems pretty extreme) without other errors. Since CSCValidation has absolutely nothing to do with any CMSSW workflows even doing that seems like a complete waste of time.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38759/31082

• This PR adds an extra 68KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38759/31082/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38759/31082/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38759/31083

• This PR adds an extra 84KB to repository

[cmsbuild]

A new Pull Request was created by @ptcox for master.

It involves the following packages:

• RecoLocalMuon/CSCValidation (reconstruction)

@jpata, @cmsbuild, @clacaputo can you please review it and eventually sign? Thanks.
@bellan, @jhgoh this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[clacaputo]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-44d9f6/26323/summary.html
COMMIT: 81ecb03
CMSSW: CMSSW_12_5_X_2022-07-18-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38759/26323/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3662417
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3662387
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[clacaputo]

+reconstruction

• re-organization of csc validation code used by CSC DPG
• The code doesn't enter in any CMSSW workflow
• no reco changes observed, as expected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Private validation code, accepted as it is

[ptcox]

Thanks! It's basically in CMSSW for consistency and archival purposes.

…

Andrea Perrotta ***@***.***> July 20, 2022 at 19:13 +1 * Private validation code, accepted as it is — Reply to this email directly, view it on GitHub <#38759 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGYLHWJ6XHAKRKCKXTWLOTVVAXVLANCNFSM53WHB7XA>. You are receiving this because you were mentioned.Message ID: ***@***.***>