Add missing line for SubProcess unit test diff

[qliphy]

PR description:

This fixes the unit test diff.
See the unit test error error reported in #38728 (comment)

PR validation:

Test now passes.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of #38754

[cmsbuild]

A new Pull Request was created by @qliphy (Qiang Li) for CMSSW_12_4_X.

It involves the following packages:

• FWCore/Integration (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Add missing line for SubProcess unit test diff #38754

[qliphy]

please test

[Dr15Jones]

Ah, you beat me to it :)

[perrotta]

@qliphy @Dr15Jones thank both you!

[perrotta]

backport of #38754

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-287617/26269/summary.html
COMMIT: ea69426
CMSSW: CMSSW_12_4_X_2022-07-15-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38756/26269/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestSubProcess had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3676111
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3676081
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[makortel]

The test failed now in the other way around

Running script: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_4_X_2022-07-15-1100/src/FWCore/Integration/test/run_SubProcess.sh
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_4_X_2022-07-15-1100/tmp/el8_amd64_gcc10 /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_4_X_2022-07-15-1100
cmsRun testSubProcess_cfg.py
15d14
<    25 Tracer               -s DoodadESSource:D                       4        4
Failure comparing testSubProcess.grep.txt: status 1
status = 256

---> test TestSubProcess had ERRORS

presumably because #38742 was not included in the test.

[makortel]

@cmsbuild, please test

[perrotta]

@makortel I plan to merge this now anyhow, since we want to cut 12_3_4 by tomorrow, and I'd prefer having clean unit tests with it

[makortel]

+1

Ok

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

merge
(with the intention to fix the now broken unit test in time for 12_4_3)

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-287617/26273/summary.html
COMMIT: ea69426
CMSSW: CMSSW_12_4_X_2022-07-15-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38756/26273/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestSubProcess had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3676111
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3676075
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[perrotta]

@makortel
"25" should be a "24" in 12_4_X (whatever it means...)

[qliphy]

@perrotta Thanks for the suggestion, it indeed works with 12_4_X. A new fix is made: #38767 38767