[Backport of] HCAL: Bugfix of PFA1' Trigger Primitive algo by switching to integer based math

[Michael-Krohn]

PR description:

Switching from double variable based math to integer variable based math in the TP energy algorithm. This is to match what is in the firmware on detector. Also, the logic blocks to perform the energy calculation for PFA1' and PFA2 have been separated. Again to match what is in the firmware on detector.

PR validation:

A basic technical test was performed: runTheMatrix.py -l limited -i all --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a backport of PR #38753 to 124X, in order to make s/w match f/w.

[cmsbuild]

A new Pull Request was created by @Michael-Krohn for CMSSW_12_4_X.

It involves the following packages:

• SimCalorimetry/HcalTrigPrimAlgos (l1)
• SimCalorimetry/HcalTrigPrimProducers (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@bsunanda, @abdoulline, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from HCAL: Bugfix of PFA1' Trigger Primitive algo by switching to integer based math #38753

[mariadalfonso]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b685b/26284/summary.html
COMMIT: c961014
CMSSW: CMSSW_12_4_X_2022-07-16-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38755/26284/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3676111
• DQMHistoTests: Total failures: 1138
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3674950
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: found differences in 2 / 49 workflows

[mariadalfonso]

type bug-fix

[mariadalfonso]

ideally we want this for the Run3-MC
as this brings the software into agreement with the firmware for Run3

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

Pull request #38755 was updated. @epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please check and sign again.

[cmsbuild]

Pull request #38755 was updated. @epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please check and sign again.

[cmsbuild]

Pull request #38755 was updated. @epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please check and sign again.

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b685b/26387/summary.html
COMMIT: 6baef2b
CMSSW: CMSSW_12_4_X_2022-07-21-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38755/26387/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3676198
• DQMHistoTests: Total failures: 562
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3675613
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: found differences in 2 / 49 workflows

[perrotta]

@cms-sw/l1-l2 do you see any issue with this backport? Master version of this PR was merged since CMSSW_12_5_X_2022-07-22-2300

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1