-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use tbb::task_group::defer in FinalWaitingTask #38715
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
#ifndef FWCore_Concurrency_FinalWaitingTask_h | ||
#define FWCore_Concurrency_FinalWaitingTask_h | ||
// -*- C++ -*- | ||
// | ||
// Package: FWCore/Concurrency | ||
// Class : FinalWaitingTask | ||
// | ||
/**\class FinalWaitingTask FinalWaitingTask.h "FWCore/Concurrency/interface/FinalWaitingTask.h" | ||
|
||
Description: [one line class summary] | ||
|
||
Usage: | ||
Use this class on the stack to signal the final task to be run. | ||
Call done() to check to see if the task was run and check value of | ||
exceptionPtr() to see if an exception was thrown by any task in the group. | ||
|
||
*/ | ||
// | ||
// Original Author: Christopher Jones | ||
// Created: Tue, 12 Jul 2022 18:45:15 GMT | ||
// | ||
|
||
// system include files | ||
#include "oneapi/tbb/task_group.h" | ||
|
||
// user include files | ||
#include "FWCore/Concurrency/interface/WaitingTask.h" | ||
|
||
// forward declarations | ||
namespace edm { | ||
class FinalWaitingTask : public WaitingTask { | ||
public: | ||
FinalWaitingTask() = delete; | ||
explicit FinalWaitingTask(tbb::task_group& iGroup) | ||
: m_group{&iGroup}, m_handle{iGroup.defer([]() {})}, m_done{false} {} | ||
|
||
void execute() final { m_done = true; } | ||
|
||
[[nodiscard]] bool done() const noexcept { return m_done.load(); } | ||
|
||
void wait() { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we care about having similar nomenclature with SYCL queues? (asking since SYCL/DPC++ is part of the oneAPI) There the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we care at all. I went with consistency with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Right, consistency with oneTBB's nomenclature is more important. |
||
m_group->wait(); | ||
if (exceptionPtr()) { | ||
std::rethrow_exception(exceptionPtr()); | ||
} | ||
} | ||
std::exception_ptr waitNoThrow() { | ||
m_group->wait(); | ||
return exceptionPtr(); | ||
} | ||
|
||
private: | ||
void recycle() final { m_group->run(std::move(m_handle)); } | ||
tbb::task_group* m_group; | ||
tbb::task_handle m_handle; | ||
std::atomic<bool> m_done; | ||
}; | ||
|
||
} // namespace edm | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if always adding an empty deferred task could add any visible overhead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is only used when shutting down the event loop so I doubt it can be seen at all.