-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GT for DQM clients unitTests and input file used for unitTest #38712
Conversation
test parameters: |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38712/31011
|
A new Pull Request was created by @francescobrivio for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test TestDQMOnlineClient-gem_dqm_sourceclient had ERRORS Comparison SummarySummary:
|
this PR can also work standalone, and this set of commands runs fine:
would it make sense to decouple it from the update of the GEM alignment and let it go in, independently? |
Yes I agree, let's go independently so it can be integrated in the IBs |
test parameters: |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-869767/26190/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
With the activation of the GEMAlignment in #38666 and the update of the GTs in #38692, some DQM unitTests were failing due to the fact that they were still using the
auto:run2_data
GT, this PR updates them toauto:run3_data
(even the ones were the GT is actually commented out, but I guess it is useful to have it updated when running privately).I profit of the same PR to update the file used in the DQM unitTest from a 2021 cosmics run, to an ExpressPhysics FEVT 2022 collision run at 13.6 TeV which seems more appropriate for testing the clients in Run 3.
PR validation:
scram b runtests
runs fine including the new GTs and the activation of the GEMAlignmentIf this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, but a 12_4_X backport will be provided