Updated list of Geant4 process codes #38659
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38659/30945
|
|
A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master. It involves the following packages:
@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Expand to see more relval errors ...Comparison SummarySummary:
|
cmsbuild
added
code-checks-pending
tests-pending
and removed
tests-rejected
code-checks-approved
labels
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38659/31116
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38659/31119
|
|
Pull request #38659 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again. |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b2d1d/26313/summary.html Comparison SummarySummary:
|
|
+1 |
cmsbuild
added
fully-signed
simulation-approved
and removed
simulation-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
| "PairProdCharged", "Annih", "AnnihToMuMu", "AnnihToHad", "NuclearStopp", "Msc", | ||
| "Rayleigh", "PhotoElectric", "Compton", "Conv", "ConvToMuMu", "Cerenkov", | ||
| "Scintillation", "SynchRad", "TransRad", "OpAbsorp", "OpBoundary", "OpRayleigh", | ||
| "OpWLS", "OpMieHG", "DNAElastic", "DNAExcit", "DNAIonisation", "DNAVibExcit", |
There was a problem hiding this comment.
@civanch Is it on purpose to remove "DNAElastic" and "DNAExcit"?
There was a problem hiding this comment.
@qliphy , all DNA processes in this list are not used in CMSSW and are not planned to be used - it is low-energy processes in liquid water for studying of low-dose radiation effects on biological molecules. They appears in our list due to historical circumstances. What is important for CMSSW: all other processes should stay with the same indexes and names. So, for us DNA processes are placeholders. In this PR two rare processes for exotica analysis are added instead of two DNA processes. This is safe.
|
+1 |
custom physics. Renamed cross section biasing operators to use .cc instead of .cxx naming Removed or replaced printf and cout statements with edm::LogVerbatim Moved include statements from interface to source files when unused in header. Made header methods using the delete keyword public Changed dark bremsstrahlung process from G4VEnergyLossProcess to G4VEmProcess, changed process ordering from 1 to 6. Moved Dark Brem Watcher from plugins/ to src/ Added necessary includes for DBremWatcher in CustomPhysics/src/ to BuildFile Implemented clang code checks Modified dark brem process subtype to use subtype 40, added in PR cms-sw#38659 Removed biasing physics interface used for dark brem cross section biasing and replaced with direct multiplier of calculated cross section.
PR description:
Added extra types of Geant4 process. All previously used process types are not changed. PR itself should change nothing for any WF.
PR validation:
private
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Will be backported to 10_6 and 12_4 for dark matter bremsstrahlung for Run2 and Run3