-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update errorScale for BeamSpot Legacy DQM client #38632
Conversation
@cmsbuild please test |
+db
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38632/30920
|
A new Pull Request was created by @francescobrivio for master. It involves the following packages:
@emanueleusai, @ahmad3213, @jfernan2, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fadd5e/26054/summary.html Comparison SummarySummary:
|
@cms-sw/dqm-l2 you signed the backport version of this PR, and not this one in the master: should I give the signature here for granted and bypasss it, or is there any reason for not signing this onw? |
+1
|
merge |
apologies for whatever reason I missed this in our PR tracking tool |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
Forward-port of #38618 (12_3_X PR)
This PR updates the
errorScale
parameter from 1.22 to 1.0, see the 12_3_X PR for more detailsPR validation:
The 12_3_X PR (#38618) deployed in production in Fill 7923 shows the beamspot legacy client properly working, see #38618 (comment) and #38618 (comment)
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Forward port of #38618
Backports to 12_4_X and 12_3_X will be provided