fix Radix Sort for size = N*256+1

[VinInn]

As the title says.

purely technical.
no regression expected as used in production only for vertex sorting that never exceeds 100 or so.

thanks @cericeci for pointing out the failure and provide a test

[VinInn]

@AdrianoDee @cericeci FYI

[AdrianoDee]

test parameters:

• enable_tests = gpu
• workflows_gpu = 11634.502
• relvals_opt= -w standard,highstats,pileup,generator,extendedgen,production,upgrade,cleanedupgrade,ged

[AdrianoDee]

please test

[AdrianoDee]

Thanks Vincenzo

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38599/30870

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File HeterogeneousCore/CUDAUtilities/test/BuildFile.xml modified in PR(s): New Heterogeneous Memory Pool #37952, Use cooperative groups to populate Associations (Histograms) in Pixel Patatrack #35713

[cmsbuild]

A new Pull Request was created by @VinInn (Vincenzo Innocente) for master.

It involves the following packages:

• HeterogeneousCore/CUDAUtilities (heterogeneous)

@makortel, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61e992/25984/summary.html
COMMIT: ce4bd6e
CMSSW: CMSSW_12_5_X_2022-07-05-1100/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38599/25984/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 5
• DQMHistoTests: Total histograms compared: 35871
• DQMHistoTests: Total failures: 17
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 35854
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 4 files compared)
• Checked 16 log files, 12 edm output root files, 5 DQM output files
• TriggerResults: no differences found

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3654771
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3654741
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[fwyzard]

+heterogeneous

Sorry for the delay, I missed it while I was away.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[fwyzard]

type bugfix

[perrotta]

+1