Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-hgx318 Add a scenario 2026D94 using HGCal version V17 and HFNose #38596

Merged
merged 2 commits into from
Jul 6, 2022

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Jul 5, 2022

PR description:

Add a scenario 2026D94 using HGCal version V17 and HFNose

PR validation:

Use theTheMatrix test workflow 41834.0 and overlap checking tool

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38596/30857

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2022

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Configuration/Geometry (geometry, upgrade)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)
  • Geometry/CMSCommonData (geometry, upgrade)
  • Geometry/ForwardCommonData (geometry)
  • Geometry/HGCalCommonData (geometry, upgrade)
  • SimG4Core/PrintGeomInfo (simulation)

@perrotta, @civanch, @Dr15Jones, @jordan-martins, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @bbilin, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@beaucero, @fabiocos, @vargasa, @makortel, @cvuosalo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @ebrondol, @kpedro88, @lecriste, @felicepantaleo, @trtomei, @mmusich, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38596/30859

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2022

Pull request #38596 was updated. @perrotta, @civanch, @Dr15Jones, @jordan-martins, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @bbilin, @qliphy, @fabiocos, @davidlange6 can you please check and sign again.

@srimanob
Copy link
Contributor

srimanob commented Jul 5, 2022

test parameters:

  • workflow = 41834.0

@srimanob
Copy link
Contributor

srimanob commented Jul 5, 2022

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2829c9/25988/summary.html
COMMIT: 2b512e3
CMSSW: CMSSW_12_5_X_2022-07-05-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38596/25988/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-2829c9/41834.0_TTbar_14TeV+2026D94+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3654771
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3654747
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Jul 6, 2022

+1

@srimanob
Copy link
Contributor

srimanob commented Jul 6, 2022

+Upgrade

This PR add new D94 (HGCal V17 + HFNose). The new workflow runs fine. No change in other workflows.

@kskovpen
Copy link
Contributor

kskovpen commented Jul 6, 2022

+pdmv

Copy link
Contributor

@perrotta perrotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usage of a safer syntax must be preferred, to prevent possible mistakes.
Ok to defer it to some future cleanup PR

Comment on lines +6 to +11
name = cms.string("HGCalHFNoseSensitive"),
name2 = cms.string("HFNoseEE"),
nameW = cms.string("HFNoseWafer"),
nameC = cms.string("HFNoseCell"),
nameT = cms.string("HFNose"),
nameX = cms.string("HGCalHFNoseSensitive"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = cms.string("HGCalHFNoseSensitive"),
name2 = cms.string("HFNoseEE"),
nameW = cms.string("HFNoseWafer"),
nameC = cms.string("HFNoseCell"),
nameT = cms.string("HFNose"),
nameX = cms.string("HGCalHFNoseSensitive"),
name = "HGCalHFNoseSensitive",
name2 = "HFNoseEE",
nameW = "HFNoseWafer",
nameC = "HFNoseCell",
nameT = "HFNose",
nameX = "HGCalHFNoseSensitive"

(safer syntax, as already in Geometry/HGCalCommonData/python/hgcalV15ParametersInitialization_cfi.py

@perrotta
Copy link
Contributor

perrotta commented Jul 6, 2022

The usage of a safer syntax must be preferred, to prevent possible mistakes. Ok to defer it to some future cleanup PR

See #38604

@perrotta
Copy link
Contributor

perrotta commented Jul 6, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 44487ef into cms-sw:master Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants