-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-hgx318 Add a scenario 2026D94 using HGCal version V17 and HFNose #38596
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38596/30857
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@perrotta, @civanch, @Dr15Jones, @jordan-martins, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @bbilin, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38596/30859
|
Pull request #38596 was updated. @perrotta, @civanch, @Dr15Jones, @jordan-martins, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @bbilin, @qliphy, @fabiocos, @davidlange6 can you please check and sign again. |
test parameters:
|
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2829c9/25988/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+1 |
+Upgrade This PR add new D94 (HGCal V17 + HFNose). The new workflow runs fine. No change in other workflows. |
+pdmv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The usage of a safer syntax must be preferred, to prevent possible mistakes.
Ok to defer it to some future cleanup PR
name = cms.string("HGCalHFNoseSensitive"), | ||
name2 = cms.string("HFNoseEE"), | ||
nameW = cms.string("HFNoseWafer"), | ||
nameC = cms.string("HFNoseCell"), | ||
nameT = cms.string("HFNose"), | ||
nameX = cms.string("HGCalHFNoseSensitive"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name = cms.string("HGCalHFNoseSensitive"), | |
name2 = cms.string("HFNoseEE"), | |
nameW = cms.string("HFNoseWafer"), | |
nameC = cms.string("HFNoseCell"), | |
nameT = cms.string("HFNose"), | |
nameX = cms.string("HGCalHFNoseSensitive"), | |
name = "HGCalHFNoseSensitive", | |
name2 = "HFNoseEE", | |
nameW = "HFNoseWafer", | |
nameC = "HFNoseCell", | |
nameT = "HFNose", | |
nameX = "HGCalHFNoseSensitive" |
(safer syntax, as already in Geometry/HGCalCommonData/python/hgcalV15ParametersInitialization_cfi.py
See #38604 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
Add a scenario 2026D94 using HGCal version V17 and HFNose
PR validation:
Use theTheMatrix test workflow 41834.0 and overlap checking tool
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Nothing special