Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Run3_ckfPixelLessStep to StandardSequences #38563

Closed

Conversation

francescobrivio
Copy link
Contributor

@francescobrivio francescobrivio commented Jun 30, 2022

PR description:

Add the new Run3_ckfPixelLessStep era (introduced in #38437) to Configuration/StandardSequences/python/Eras.py.

While starting the release validation of CMSSW_12_4_1, @bbilin noticed that the driver was failing with the error:

raise Exception( "'%s' is not a valid option for '--era'. Valid options are %s." % (eraName, validOptions) )
Exception: 'Run3_ckfPixelLessStep' is not a valid option for '--era'. Valid options are 'Run1_pA', 'Run1_peripheralPbPb', 'Run2_50ns', 'Run2_50ns_HIPM', 'Run2_25ns', 'Run2_25ns_HIPM', 'Run2_25ns_peripheralPbPb', 'Run2_HI', 'Run2_2016', 'Run2_2016_HIPM', ....

So the new era was not recognized.
With the input from @mmusich I added the new era (and the modifier) in the (hopefully) correct place.

At the same time the era cfg was wrongly named Era_Run3_ckfPixelLessStep.py instead of Configuration/Eras/python/Era_Run3_ckfPixelLessStep_cff.py. This is fixed in this PR as well.

PR validation:

N/A

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, a backport to 12_4_X will be needed

@francescobrivio
Copy link
Contributor Author

FYI @cms-sw/reconstruction-l2

@mmusich
Copy link
Contributor

mmusich commented Jun 30, 2022

@mmasciov @slava77

@tvami
Copy link
Contributor

tvami commented Jun 30, 2022

urgent

@tvami
Copy link
Contributor

tvami commented Jun 30, 2022

@cmsbuild please test

  • tho nothing tests this anyway...

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38563/30810

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • Configuration/StandardSequences (operations)

@perrotta, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @lecriste, @mtosi, @ebrondol, @mmusich, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Jun 30, 2022

can we please add a workflow that tests this?

@tvami
Copy link
Contributor

tvami commented Jun 30, 2022

@cmsbuild , please abort

@francescobrivio
Copy link
Contributor Author

type bug-fix

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38563/30813

@cmsbuild
Copy link
Contributor

Pull request #38563 was updated. @cmsbuild, @perrotta, @qliphy, @fabiocos, @davidlange6 can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Jun 30, 2022

duplicate of #38565

@mmasciov
Copy link
Contributor

@francescobrivio, @mmusich, @slava77, @tvami, @bbilin:
this issue is fixed in PR #38565 (and its backport to 124X, PR #38566).
After the second commit, however, this PR is fully equivalent to #38565.
In the description of PR #38565 and PR #38566, a validation is linked, explicitly checking that the new era is fully recognized, and does what's expected.

@francescobrivio francescobrivio changed the title [RFC] Add new Run3_ckfPixelLessStep to StandardSequences Add new Run3_ckfPixelLessStep to StandardSequences Jun 30, 2022
@francescobrivio
Copy link
Contributor Author

closing in favor of #38565

@francescobrivio francescobrivio deleted the alca-MC_12_4_X_production branch June 30, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants