-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Run3_ckfPixelLessStep to StandardSequences #38563
Add new Run3_ckfPixelLessStep to StandardSequences #38563
Conversation
FYI @cms-sw/reconstruction-l2 |
urgent |
@cmsbuild please test
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38563/30810
|
A new Pull Request was created by @francescobrivio for master. It involves the following packages:
@perrotta, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
can we please add a workflow that tests this? |
@cmsbuild , please abort |
95053de
to
f0c6331
Compare
type bug-fix |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38563/30813
|
duplicate of #38565 |
@francescobrivio, @mmusich, @slava77, @tvami, @bbilin: |
closing in favor of #38565 |
PR description:
Add the new
Run3_ckfPixelLessStep
era (introduced in #38437) toConfiguration/StandardSequences/python/Eras.py
.While starting the release validation of CMSSW_12_4_1, @bbilin noticed that the driver was failing with the error:
So the new era was not recognized.
With the input from @mmusich I added the new era (and the modifier) in the (hopefully) correct place.
At the same time the era cfg was wrongly named
Era_Run3_ckfPixelLessStep.py
instead ofConfiguration/Eras/python/Era_Run3_ckfPixelLessStep_cff.py
. This is fixed in this PR as well.PR validation:
N/A
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, a backport to 12_4_X will be needed