-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gen fragment for LLP relval #38496
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38496/30719
|
A new Pull Request was created by @kakwok for master. It involves the following packages:
@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @alberto-sanchez can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6e2a0/25835/summary.html Comparison SummarySummary:
|
@kakwok , thanks for the PR. Have you performed validation locally on this fragment? Do you mind sharing it here? Thanks |
Hi @SiewYan , do you have instructions to perform the validation? Is this good enough? |
Hi, do you want this to target 13.6 TeV or 14 TeV? Run III is 13.6 TeV as you know. |
Following up, since this a configuration file: |
Hi @Saptaparna, thanks for your help! I've updated the PR as per your suggestion. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38496/30944
|
-1 |
Awaiting changes suggested on #38496 (comment) |
@kakwok , do you have any update on the suggested changes? Thanks. |
@SiewYan Sorry for the late response. Just fixed it. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38496/31239
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6e2a0/26432/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This PR is for adding the gen-fragment for relval sample for the new LLP seeds as per dicussion here:
https://its.cern.ch/jira/browse/PDMVRELVALS-152
The fragment is taken from the signal sample used in the TSG sample:
https://cms-pdmv.cern.ch/mcm/public/restapi/requests/get_fragment/HCA-Run3Winter20GS-00030/0
The backport to 12_4_X is #38490