Initialise the errors_ data member of SiPixelDigiErrorsSoAFromCUDA [12.3.x]

[fwyzard]

PR description:

Initialise the errors_ data member of the SiPixelDigiErrorsSoAFromCUDA producer.

Prevents reading from uninitialised memory when the first event of a job has zero error words, and fixes a crash observed at HLT during data taking.

PR validation:

Without this fix, it is possible to reproduce the error observed online running over the "error stream" events that triggered it.
With this fix, no crash is observed after running 30+ times on the same input.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #38476, needed for data taking.

[fwyzard]

type bug-fix

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_12_3_X.

It involves the following packages:

• EventFilter/SiPixelRawToDigi (reconstruction)

@jpata, @cmsbuild, @clacaputo can you please review it and eventually sign? Thanks.
@OzAmram, @VinInn, @Martin-Grunewald, @missirol, @dkotlins, @ferencek, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Initialise the errors_ data member of SiPixelDigiErrorsSoAFromCUDA #38476

[fwyzard]

backport #38476

[fwyzard]

urgent

[fwyzard]

enable gpu

[fwyzard]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4868e8/25709/summary.html
COMMIT: a19a087
CMSSW: CMSSW_12_3_X_2022-06-22-1100/slc7_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38478/25709/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 24 differences found in the comparisons
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19864
• DQMHistoTests: Total failures: 997
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 18867
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: no differences found

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3630290
• DQMHistoTests: Total failures: 19
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3630248
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[clacaputo]

+reconstruction

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1