Add to Pythia8Interface the plugin that uses HepMC3 #38452

mkirsano · 2022-06-21T17:46:34Z

PR description:

The new plugin produces HepMC3 products. For the moment only GEN step can be run like this.

PR validation:

Local tests using the new configurations in /test

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild · 2022-06-21T17:53:50Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38452/30660

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File GeneratorInterface/Pythia8Interface/BuildFile.xml modified in PR(s): Add to Pythia8Interface the plugin that produces HepMC3 products #37753
- File GeneratorInterface/Pythia8Interface/interface/Py8HMC3InterfaceBase.h modified in PR(s): Add to Pythia8Interface the plugin that produces HepMC3 products #37753
- File GeneratorInterface/Pythia8Interface/plugins/BuildFile.xml modified in PR(s): Add to Pythia8Interface the plugin that produces HepMC3 products #37753
- File GeneratorInterface/Pythia8Interface/plugins/LHAupLesHouches.h modified in PR(s): Add to Pythia8Interface the plugin that produces HepMC3 products #37753
- File GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc modified in PR(s): Add to Pythia8Interface the plugin that produces HepMC3 products #37753
- File GeneratorInterface/Pythia8Interface/plugins/Pythia8HepMC3Hadronizer.cc modified in PR(s): Add to Pythia8Interface the plugin that produces HepMC3 products #37753
- File GeneratorInterface/Pythia8Interface/src/Py8HMC3InterfaceBase.cc modified in PR(s): Add to Pythia8Interface the plugin that produces HepMC3 products #37753
- File GeneratorInterface/Pythia8Interface/test/pythia8hmc3ex2_cfg.py modified in PR(s): Add to Pythia8Interface the plugin that produces HepMC3 products #37753
- File GeneratorInterface/Pythia8Interface/test/pythia8hmc3ex3_cfg.py modified in PR(s): Add to Pythia8Interface the plugin that produces HepMC3 products #37753

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38452/30660/code-checks.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38452/30660/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38452/30660/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38452/30660/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2022-06-21T20:15:49Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38452/30664

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File GeneratorInterface/Pythia8Interface/BuildFile.xml modified in PR(s): Add to Pythia8Interface the plugin that produces HepMC3 products #37753
- File GeneratorInterface/Pythia8Interface/interface/Py8HMC3InterfaceBase.h modified in PR(s): Add to Pythia8Interface the plugin that produces HepMC3 products #37753
- File GeneratorInterface/Pythia8Interface/plugins/BuildFile.xml modified in PR(s): Add to Pythia8Interface the plugin that produces HepMC3 products #37753
- File GeneratorInterface/Pythia8Interface/plugins/LHAupLesHouches.h modified in PR(s): Add to Pythia8Interface the plugin that produces HepMC3 products #37753
- File GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc modified in PR(s): Add to Pythia8Interface the plugin that produces HepMC3 products #37753
- File GeneratorInterface/Pythia8Interface/plugins/Pythia8HepMC3Hadronizer.cc modified in PR(s): Add to Pythia8Interface the plugin that produces HepMC3 products #37753
- File GeneratorInterface/Pythia8Interface/src/Py8HMC3InterfaceBase.cc modified in PR(s): Add to Pythia8Interface the plugin that produces HepMC3 products #37753
- File GeneratorInterface/Pythia8Interface/test/pythia8hmc3ex2_cfg.py modified in PR(s): Add to Pythia8Interface the plugin that produces HepMC3 products #37753
- File GeneratorInterface/Pythia8Interface/test/pythia8hmc3ex3_cfg.py modified in PR(s): Add to Pythia8Interface the plugin that produces HepMC3 products #37753

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38452/30664/code-checks.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38452/30664/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38452/30664/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38452/30664/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2022-06-21T20:33:33Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38452/30665

This PR adds an extra 28KB to repository

cmsbuild · 2022-06-21T20:33:59Z

A new Pull Request was created by @mkirsano (Mikhail Kirsanov) for master.

It involves the following packages:

GeneratorInterface/Pythia8Interface (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

mkirsano · 2022-06-21T20:36:33Z

please test

cmsbuild · 2022-06-22T00:26:22Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5cf956/25669/summary.html
COMMIT: f46dc4e
CMSSW: CMSSW_12_5_X_2022-06-21-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38452/25669/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestGeneratorInterfacePythia8InterfaceCompareExternalStreams had ERRORS

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3659099
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3659075
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 208 log files, 45 edm output root files, 50 DQM output files
TriggerResults: no differences found

cmsbuild · 2022-07-12T16:26:53Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38452/31006

This PR adds an extra 16KB to repository

cmsbuild · 2022-07-12T16:27:20Z

Pull request #38452 was updated. @SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @alberto-sanchez can you please check and sign again.

mkirsano · 2022-07-12T16:28:17Z

After asking around I removed the comment that seems obsolete.

mkirsano · 2022-07-12T16:28:42Z

Note that the code is not changed

mkirsano · 2022-07-15T13:08:10Z

please test

cmsbuild · 2022-07-15T17:16:32Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5cf956/26265/summary.html
COMMIT: 921a506
CMSSW: CMSSW_12_5_X_2022-07-14-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38452/26265/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3653966
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3653936
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 208 log files, 45 edm output root files, 50 DQM output files
TriggerResults: no differences found

mkirsano · 2022-07-18T09:30:12Z

please test

cmsbuild · 2022-07-18T13:14:14Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5cf956/26303/summary.html
COMMIT: 921a506
CMSSW: CMSSW_12_5_X_2022-07-17-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38452/26303/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3654053
DQMHistoTests: Total failures: 13
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3654017
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 208 log files, 45 edm output root files, 50 DQM output files
TriggerResults: no differences found

mkirsano · 2022-07-18T13:59:07Z

+1

cmsbuild · 2022-07-18T13:59:30Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-07-18T16:36:51Z

+1

Add to Pythia8Interface the plugin that uses HepMC3

6bffc8d

cmsbuild added this to the CMSSW_12_5_X milestone Jun 21, 2022

cmsbuild added code-checks-pending generators-pending orp-pending pending-signatures tests-pending labels Jun 21, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jun 21, 2022

Fix for code-checks

89e5e55

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jun 21, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jun 21, 2022

Fix for code-checks

f46dc4e

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jun 21, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 21, 2022

cmsbuild added tests-started and removed tests-pending labels Jun 21, 2022

cmsbuild added tests-rejected and removed tests-started labels Jun 22, 2022

cmsbuild mentioned this pull request Jun 22, 2022

Powheg+Vincia matching #38471

Merged

cmsbuild added pending-signatures tests-pending labels Jul 12, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 12, 2022

cmsbuild added tests-started and removed tests-pending labels Jul 15, 2022

cmsbuild added tests-rejected and removed tests-started labels Jul 15, 2022

cmsbuild added tests-started and removed tests-rejected labels Jul 18, 2022

cmsbuild added tests-approved and removed tests-started labels Jul 18, 2022

cmsbuild added fully-signed generators-approved and removed generators-pending pending-signatures labels Jul 18, 2022

cmsbuild added orp-approved and removed orp-pending labels Jul 18, 2022

cmsbuild merged commit 0308349 into cms-sw:master Jul 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add to Pythia8Interface the plugin that uses HepMC3 #38452

Add to Pythia8Interface the plugin that uses HepMC3 #38452

mkirsano commented Jun 21, 2022

cmsbuild commented Jun 21, 2022

cmsbuild commented Jun 21, 2022

cmsbuild commented Jun 21, 2022

cmsbuild commented Jun 21, 2022

mkirsano commented Jun 21, 2022

cmsbuild commented Jun 22, 2022

cmsbuild commented Jul 12, 2022

cmsbuild commented Jul 12, 2022

mkirsano commented Jul 12, 2022

mkirsano commented Jul 12, 2022

mkirsano commented Jul 15, 2022

cmsbuild commented Jul 15, 2022

mkirsano commented Jul 18, 2022

cmsbuild commented Jul 18, 2022

mkirsano commented Jul 18, 2022

cmsbuild commented Jul 18, 2022

perrotta commented Jul 18, 2022

Add to Pythia8Interface the plugin that uses HepMC3 #38452

Add to Pythia8Interface the plugin that uses HepMC3 #38452

Conversation

mkirsano commented Jun 21, 2022

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jun 21, 2022

cmsbuild commented Jun 21, 2022

cmsbuild commented Jun 21, 2022

cmsbuild commented Jun 21, 2022

mkirsano commented Jun 21, 2022

cmsbuild commented Jun 22, 2022

Unit Tests

Comparison Summary

cmsbuild commented Jul 12, 2022

cmsbuild commented Jul 12, 2022

mkirsano commented Jul 12, 2022

mkirsano commented Jul 12, 2022

mkirsano commented Jul 15, 2022

cmsbuild commented Jul 15, 2022

RelVals-INPUT

Comparison Summary

mkirsano commented Jul 18, 2022

cmsbuild commented Jul 18, 2022

Comparison Summary

mkirsano commented Jul 18, 2022

cmsbuild commented Jul 18, 2022

perrotta commented Jul 18, 2022