-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rawprime workflow with approximated siStrip clusters for heavy ions #38423
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38423/30629
|
A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for master. It involves the following packages:
@perrotta, @jordan-martins, @bbilin, @clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @slava77, @jpata, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
assign trk-dpg |
RecoLocalTracker/SiStripClusterizer/plugins/SiStripApprox2Clusters.cc
Outdated
Show resolved
Hide resolved
RecoLocalTracker/SiStripClusterizer/plugins/SiStripApprox2Clusters.cc
Outdated
Show resolved
Hide resolved
RecoLocalTracker/SiStripClusterizer/plugins/SiStripApprox2Clusters.cc
Outdated
Show resolved
Hide resolved
RecoLocalTracker/SiStripClusterizer/python/SiStripClusterizer_RealData_cfi.py
Outdated
Show resolved
Hide resolved
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38423/30636
|
Pull request #38423 was updated. @perrotta, @connorpa, @kskovpen, @jordan-martins, @bbilin, @clacaputo, @cmsbuild, @AdrianoDee, @srimanob, @tsusa, @slava77, @jpata, @qliphy, @mmusich, @fabiocos, @davidlange6 can you please check and sign again. |
test parameters:
|
+pdmv |
+1 |
+reconstruction |
@cms-sw/upgrade-l2 your signature was requested because of Configuration/PyReleaseValidation (pdmv, upgrade) |
+Upgrade For Upgrade, this PR adds step and workflow to |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
This PR contains the code needed to run a full reconstruction workflow using a modified data format which explicitly stores an approximated version of siStripClusters rather than full strip tracker RAW information. The motivation for this is to reduce the size of the RAW data format to more efficiently utilize HLT bandwidth during Run 3 (see slides 1-6 here) [1]. The approximated siStripClusters assume a rectangular cluster shape rather than storing a detailed list of ADC counts for each cluster. Note that the RAW data size is not actually reduced in this PR, this will come in second PR.
These approximated clusters are interfaced with the rest of the tracking sequence by converting them back into a collection of SiStripCluster objects at the beginning of the local reco sequence (instead if generating the clusters from RAW data). We have found that the changes to the cluster shape cause small differences in the tracking, on the order of 1% or less in MB heavy ion data, with the new procedure having slightly less tracks. A summary of the tracking performance using the performance of the 2018 reconstruction as a baseline can be found at [2]. This has been shown multiple times in HI PAG meetings.
It should be noted that we also turn off the cluster subshape filter in the pixelless and tob/tec tracking iterations. These were found to have a large sensitivity to the approximated cluster procedure, but were not found to strongly affect the tracking output when using regular clusters. Thus, we believe it is better to just remove this from the sequence.
Based on small tests with MB events, we expect a modest (~2%) increase in the timing of the reconstruction with this change, due to the removal of cluster shape filters, and no significant effect on memory usage.
[1] https://indico.cern.ch/event/1028779/contributions/4319687/attachments/2227865/3774300/RAW_DataFormat_Run3_Baty.pdf
[2] https://indico.cern.ch/event/1170543/contributions/4916527/attachments/2460140/4217789/ApproximateClustersHI_June10.pdf
PR validation:
This PR may be tested by the new relval worflows 161 (MC) and 140.58 (Run 2 data), which add a "RawPrime" step. Note that in Run 3 the functionality will be implemented instead in the HLT menu, such that it will already be applied in the input RAW data.
@abaty @icali
if this PR is a backport please specify the original PR and why you need to backport that PR:
Before submitting your pull requests, make sure you followed this checklist: