Replace trackingMkFit with trackingMkFitDevel modifier

[mmusich]

PR description:

The trackingMkFit process modifier is of historic origin and it's not actively used in any production code, though it is used in the RelVal workflows xxxxx.7.
I remove it here as it can create confusions, as well as updating the documentation and one configuration file that relied on it and replace it with a new modifier called trackingMkFitDevel which activates the mkFit replacement for all the tracking iterations (as per suggestion at #38389 (comment))
I profit of this PR to introduce a unit test for testDumpMkFitGeometry.

PR validation:

Run successfully runTheMatrix.py -l 11634.7
Also, the added unit test is running.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[mmusich]

@slava77 @mmasciov @osschar please review.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38389/30585

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• Configuration/ProcessModifiers (operations)
• RecoTracker/MkFit (reconstruction)

@perrotta, @clacaputo, @cmsbuild, @slava77, @jpata, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @ebrondol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@slava77 @mmasciov @osschar please review.

I was thinking of instead renaming this to trackingMkFitDevel, a modifier that by defaults enables mkFit in all iters, which can be also tested in the .7 workflow.
I can make that alternative by the end of the day.

[mmusich]

I can make that alternative by the end of the day.

OK, but more than an alternative it looks complementary, a modifier is removed one is added (from scratch).

[mmusich]

please test

[mmusich]

a modifier that by defaults enables mkFit in all iters, which can be also tested in the .7 workflow.

ah OK, I see now it's used here:

cmssw/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py

Lines 370 to 372 in 96319c9

	upgradeWFs['trackingMkFit'].step3 = {
	'--procModifiers': 'trackingMkFit'
	}

so the preference there is to run all iterations in the step3 of the .7 wfs?

[slava77]

so the preference there is to run all iterations in the step3 of the .7 wfs?

it's not a strong preference, but more of a way to make the .7 workflow more useful than just checking the same setup as in step3 of the default .0 already.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21fe6e/25565/summary.html
COMMIT: e37315d
CMSSW: CMSSW_12_5_X_2022-06-15-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38389/25565/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 1734 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3659074
• DQMHistoTests: Total failures: 1547
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3657504
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[slava77]

Reco comparison results: 1734 differences found in the comparisons

all differences are in 11634.7, which was changed in the implementation; that's expected.

[jpata]

+reconstruction

• repurposes the trackingMkFit modifier, renamed as trackingMkFitDevel, to enable mkFit in all tracking iterations
• tested in the workflow .7
• no other differences
• new unit test for MkFit geometry runs

[srimanob]

+Upgrade

Mostly technical on name change for trackingMkFit modifier. Additional unit test is added.

[mmusich]

@cms-sw/pdmv-l2 kind ping.

[kskovpen]

+pdmv

[perrotta]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.