Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HcalDQM: Add Hcal to DQM FED report summary map #38387

Merged
merged 2 commits into from
Jun 18, 2022

Conversation

lwang046
Copy link
Contributor

PR description:

Adding a new class HcalFEDIntegrityTask to enable HCAL to be included into the DQM FED report summary map.
fedFatal histogram contains feds that: 1, are listed as problematic from the HcalUnpackerReport; 2, have severe mismatches in event info comparing to uHTR data, same as the RawTask summary map.

PR validation:

Testes and verified with actual data from recent Run#352567 using cmsRun fed_dqm_sourceclient-live_cfg.py inputFiles=xxx

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38387/30581

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lwang046 for master.

It involves the following packages:

  • DQM/HcalTasks (dqm)
  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@DryRun, @battibass, @abdoulline, @bsunanda, @francescobrivio, @threus, @batinkov this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c2b4a7/25602/summary.html
COMMIT: 95f878d
CMSSW: CMSSW_12_5_X_2022-06-17-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38387/25602/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3659074
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3659050
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

type hcal

@cmsbuild cmsbuild added the hcal label Jun 18, 2022
@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@emanueleusai
Copy link
Member

@lwang046 are you preparing a backport of this?

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d564ee3 into cms-sw:master Jun 18, 2022
@lwang046
Copy link
Contributor Author

@lwang046 are you preparing a backport of this?

Okay I'll prepare a back port for use at p5.

lwang046 pushed a commit to lwang046/cmssw that referenced this pull request Jun 20, 2022
cmsbuild added a commit that referenced this pull request Jun 24, 2022
HcalDQM: Add FED integrity module, backport of #38387
@qliphy
Copy link
Contributor

qliphy commented Jun 24, 2022

@lwang046 Please also back port it to 12_4_X.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants