-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HcalDQM: Add Hcal to DQM FED report summary map #38387
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38387/30581
|
A new Pull Request was created by @lwang046 for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c2b4a7/25602/summary.html Comparison SummarySummary:
|
type hcal |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
@lwang046 are you preparing a backport of this? |
+1 |
Okay I'll prepare a back port for use at p5. |
HcalDQM: Add FED integrity module, backport of #38387
@lwang046 Please also back port it to 12_4_X. |
PR description:
Adding a new class
HcalFEDIntegrityTask
to enable HCAL to be included into the DQM FED report summary map.fedFatal histogram contains feds that: 1, are listed as problematic from the HcalUnpackerReport; 2, have severe mismatches in event info comparing to uHTR data, same as the
RawTask
summary map.PR validation:
Testes and verified with actual data from recent Run#352567 using
cmsRun fed_dqm_sourceclient-live_cfg.py inputFiles=xxx