Change at CaloLayer1 DQM the filling threshold for ECAL 5BX plots

[hftsoi]

PR description:

This PR is to modify the CaloLayer1 DQM, raising the TP energy threshold for filling the FAT event histograms for ECAL's pre-firing studies. The old threshold has been at 1 GeV, which is too low and the plots are dominated by detector noise seen in previous cosmic runs. The new threshold is set at 4 GeV, which should be well above the average noise levels reported by ECAL. Filling conditions are also added to be consistent with normal events filling, i.e. do not fill if there is problematic tower masked etc.

PR validation:

The codes are tested by running offline DQM on recent runs with unstable beams collisions, which has more high energy TPs to see the real effects. The DQM plots are properly filled and the ECAL experts are satisfied with this modification.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38361/30550

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @hftsoi (Ho-Fung Tsoi) for master.

It involves the following packages:

• DQM/L1TMonitor (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[emanueleusai]

please test

[emanueleusai]

type ecal

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1cf8b/25513/summary.html
COMMIT: a94c425
CMSSW: CMSSW_12_5_X_2022-06-14-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38361/25513/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3659074
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3659044
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[hftsoi]

Hi, I don't think the failed test has anything to do with this PR (similar failing was seen in #35873), could you please check? Thanks.

[emanueleusai]

yup that's right, let's retest

[emanueleusai]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b1cf8b/25600/summary.html
COMMIT: a94c425
CMSSW: CMSSW_12_5_X_2022-06-17-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38361/25600/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3659074
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3659044
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1