Code Fix to read tower geometry correctly in Ecal DQM StatusManager [12_3_X]

[abhih1]

PR description:

This PR fixes the code to read tower geometry correctly in Ecal DQM StatusManager.
Additionally the toGet method of accessing the DB tags is removed from the Ecal DQM config, on the suggestion of AlcaDB.

PR validation:

PR is validated by running a local test which creates an sqlite file which is uploaded to the DB and verified with an online DQM run on a test DQM GUI. Everything looks as expected.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #38357
Backport needed to maintain continuity in production versions

[cmsbuild]

A new Pull Request was created by @abhih1 (Abhirami Harilal) for CMSSW_12_3_X.

It involves the following packages:

• DQM/EcalCommon (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @thomreis, @argiro this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Code Fix to read tower geometry correctly in Ecal DQM StatusManager [Master] #38357

[emanueleusai]

please test

[emanueleusai]

type ecal

[emanueleusai]

backport of #38357

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac5f1a/25512/summary.html
COMMIT: 02030fb
CMSSW: CMSSW_12_3_X_2022-06-14-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38360/25512/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3630290
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3630266
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[cmsbuild]

Pull request #38360 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

[tvami]

assign alca

[cmsbuild]

New categories assigned: alca

@yuanchao,@francescobrivio,@malbouis,@tvami you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

Pull request #38360 was updated. @malbouis, @yuanchao, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @francescobrivio, @micsucmed, @rvenditti can you please check and sign again.

[tvami]

@cmsbuild , please test

[tvami]

+alca

• that unit test is knowns to fail, has nothing to do with this PR
• otherwise the relevant unit test passes
• [12_3_X] Update HLT GT with ECAL DQM tower and channel status tags #38459 should merge first

[emanueleusai]

testing at P5

[francescobrivio]

urgent

• I understood from Rosma this was succesfully tested in P5

[abhih1]

urgent

* I understood from Rosma this was succesfully tested in P5

If this is the P5 online playback of this PR run 354296: https://cmsweb.cern.ch/dqm/online-playback/session
then the tag is not working. The red towers in the ECAL summary plots should be dark red/dark yellow if the tag has gone through.
Please do not merge unless this is corrected.

[tvami]

I dont think that's that playback.
The GT is incorrect
https://cmsweb.cern.ch/dqm/online-playback/start?runnr=0;dataset=/Global/Online/ALL;sampletype=live;filter=all;referencepos=overlay;referenceshow=customise;referencenorm=True;referenceobj1=refobj;referenceobj2=none;referenceobj3=none;referenceobj4=none;search=;striptype=object;stripruns=;stripaxis=run;stripomit=none;workspace=Info;size=M;root=Quick%20collection;focus=Info/ProvInfo/Globaltag;zoom=yes;

it should be v13 or the candidate we provided

https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/123X_dataRun3_HLT_v12/123X_dataRun3_HLT_v13

[francescobrivio]

urgent

* I understood from Rosma this was succesfully tested in P5

If this is the P5 online playback of this PR run 354296: https://cmsweb.cern.ch/dqm/online-playback/session then the tag is not working. The red towers in the ECAL summary plots should be dark red/dark yellow if the tag has gone through. Please do not merge unless this is corrected.

@abhih1 I think the test was done with the old GT.

@ahmad3213 @rvenditti please repeat the playback test of this PR using HLT GT: 123X_dataRun3_HLT_v13
Thanks!

[abhih1]

Ok thanks! Dear Core DQM, Please post a link with the correct playback set so that I can verify.

[emanueleusai]

we are investigating now

[emanueleusai]

we are repeating tests with v13

[abhih1]

we are repeating tests with v13

Thanks. Looks OK now.

[emanueleusai]

it looks like you checked the results of the replay already. Everything is running ok on our side as well, so I am approving

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[qliphy]

merge