-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding HZZ electron MVA ID #38355
Adding HZZ electron MVA ID #38355
Conversation
Adding mvaHZZ variable with HZZ electron ID training. Introducing generic names for egamma IDs mvaFall17V2Iso --> mvaIso mvaFall17V2noIso --> mvanoIso
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38355/30541
|
A new Pull Request was created by @asculac (Ana Sculac) for master. It involves the following packages:
@gouskos, @clacaputo, @cmsbuild, @fgolf, @slava77, @jpata, @mariadalfonso can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e8389/25484/summary.html Comparison SummarySummary:
|
@asculac |
@@ -305,6 +309,15 @@ def _get_bitmapVIDForEle_docstring(modules,WorkingPoints): | |||
VIDNestedWPBitmapSpring15 = cms.InputTag("bitmapVIDForEleSpring15"), | |||
VIDNestedWPBitmapSum16 = cms.InputTag("bitmapVIDForEleSum16"), | |||
) | |||
(~run2_nanoAOD_preUL & run2_egamma_2016).toModify(slimmedElectronsWithUserData.userFloats, | |||
mvaHZZIso = cms.InputTag("electronMVAValueMapProducer:ElectronMVAEstimatorRun2Summer16ULIdIsoValues"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mvaHZZIso = cms.InputTag("electronMVAValueMapProducer:ElectronMVAEstimatorRun2Summer16ULIdIsoValues"), | |
mvaHZZIso = "electronMVAValueMapProducer:ElectronMVAEstimatorRun2Summer16ULIdIsoValues", |
mvaHZZIso = cms.InputTag("electronMVAValueMapProducer:ElectronMVAEstimatorRun2Summer16ULIdIsoValues"), | ||
) | ||
(~run2_nanoAOD_preUL & run2_egamma_2017).toModify(slimmedElectronsWithUserData.userFloats, | ||
mvaHZZIso = cms.InputTag("electronMVAValueMapProducer:ElectronMVAEstimatorRun2Summer17ULIdIsoValues") , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mvaHZZIso = cms.InputTag("electronMVAValueMapProducer:ElectronMVAEstimatorRun2Summer17ULIdIsoValues") , | |
mvaHZZIso = "electronMVAValueMapProducer:ElectronMVAEstimatorRun2Summer17ULIdIsoValues" , |
mvaHZZIso = cms.InputTag("electronMVAValueMapProducer:ElectronMVAEstimatorRun2Summer17ULIdIsoValues") , | ||
) | ||
(~run2_nanoAOD_preUL & run2_egamma_2018).toModify(slimmedElectronsWithUserData.userFloats, | ||
mvaHZZIso = cms.InputTag("electronMVAValueMapProducer:ElectronMVAEstimatorRun2Summer18ULIdIsoValues"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mvaHZZIso = cms.InputTag("electronMVAValueMapProducer:ElectronMVAEstimatorRun2Summer18ULIdIsoValues"), | |
mvaHZZIso = "electronMVAValueMapProducer:ElectronMVAEstimatorRun2Summer18ULIdIsoValues", |
Similarly to what @perrotta pointed out, there are more places where the same cleanup is useful
cmssw/PhysicsTools/NanoAOD/python/electrons_cff.py Lines 164 to 191 in e0f0c1c
cmssw/PhysicsTools/NanoAOD/python/electrons_cff.py Lines 269 to 310 in e0f0c1c
|
@asculac |
@cmsbuild please test Just refreshing the test results |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e8389/25831/summary.html Comparison SummarySummary:
|
Thank you for clearing it up. If this passes tests I'll immediately do the backport for 12_4_X |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38355/30985
|
Pull request #38355 was updated. @gouskos, @clacaputo, @cmsbuild, @fgolf, @jpata, @mariadalfonso can you please check and sign again. |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0e8389/26139/summary.html Comparison SummarySummary:
|
+xpog |
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
adding HZZ training for electron ID, which is an EGgamma-approved ID (latest talk at egamma POG here ) used for H->4l, which cannot otherwise be recomputed on top of nanoAODs.
It is based on the same electronMVAValueMapProducer used for existing mvaIds, but with an updated and separate training for 2016UL, 2017UL and 2018UL.
A single variable mvaHZZIso is added to electrons. The appropriate training to be used is selected automatically. The idea is that the variable name will stay the same in the future, selecting a new training when appropriate.
No need to store working points as bools since these can be easily derived from the MVA value.
In addition to this PR: renaming mva Egamma IDs to be more generic
PR validation:
@namapane @swagata87 pls follow
*this PR is a repeated clean version of previous PR (#37429)