GEM Online & Offline Efficiency Update (backport of #37954, 12_3_X) #38330

seungjin-yang · 2022-06-11T10:34:29Z

PR description:

This PR is a backport of #37954. This PR turns on the muon propagation error cuts, which mistakenly were turned off via #36883. Also, this PR simplifies the directory structure in the DQM output file and reduces redundant plots. In the offline DQM, the way to build the initial state muon propagations and a matching metric is changed. You can find more details here.
From a technical point of view, this PR adds base classes for online and offline efficiency monitors.

PR validation:

Because this PR affects both the online and the offline DQM, this PR was validated with two tests.

For the online DQM,

CMSSW_VERSION=CMSSW_12_3_X_2022-06-09-2300
cmsrel ${CMSSW_VERSION}
cd ${CMSSW_VERSION}/src
git-cms-merge-topic GEM-DQM-Eff-Update_from-${CMSSW_VERSION}
git-cms-addpkg DQM/Integration
cmsRun ${CMSSW_BASE}/src/DQM/Integration/python/clients/gem_dqm_sourceclient-live_cfg.py unitTest=True

For the offline DQM,

CMSSW_VERSION=CMSSW_12_3_X_2022-06-09-2300
cmsrel ${CMSSW_VERSION}
cd ${CMSSW_VERSION}/src
git-cms-merge-topic GEM-DQM-Eff-Update_from-${CMSSW_VERSION}
runTheMatrix.py -w upgrade -l 11611.0

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #37954. In 12_3_X, the propagation error cuts mistakenly are turned off, resulting in a lower GEM detection efficiency than expected. So, I decided to backport #37954 to 12_3_X.

cmsbuild · 2022-06-11T10:34:48Z

A new Pull Request was created by @seungjin-yang (Seungjin Yang) for CMSSW_12_3_X.

It involves the following packages:

DQM/GEM (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@watson-ij this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Backported from GEM Online & Offline Efficiency Update #37954

seungjin-yang · 2022-06-11T10:34:55Z

@jshlee @quark2

emanueleusai · 2022-06-13T06:07:01Z

please test

cmsbuild · 2022-06-13T10:00:42Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc1332/25471/summary.html
COMMIT: 7721163
CMSSW: CMSSW_12_3_X_2022-06-12-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38330/25471/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3621451
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3621421
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -1085.1599999999999 KiB( 48 files compared)
DQMHistoSizes: changed ( 11634.0,... ): -30.252 KiB GEM/Efficiency
DQMHistoSizes: changed ( 23234.0,... ): -57.619 KiB GEM/Efficiency
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
DQMHistoSizes: changed ( 35034.0,... ): -116.275 KiB GEM/Efficiency
Checked 205 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

emanueleusai · 2022-06-14T13:29:57Z

testing at P5

emanueleusai · 2022-06-14T13:52:38Z

type gem

emanueleusai · 2022-06-14T13:53:31Z

backport of #37954

emanueleusai · 2022-06-18T06:20:58Z

tests at P5 completed successfully

emanueleusai · 2022-06-18T06:21:04Z

+1

cmsbuild · 2022-06-18T06:21:22Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-06-18T14:48:04Z

PR description:

This PR is a backport of #37954. This PR turns on the muon propagation error cuts, which mistakenly were turned off via #36883.

Just to understand: is this large PR needed as a whole in the data-taking release 12_3_X just to turn on the muon propagation error cuts? If that's the only reason, perhaps a simpler fix could have been enough.

By the way, with respect to the PR in the master here the files that implement the GEMOfflineDQMBase class are not removed: was there any reason for it?

cmsbuild · 2022-06-19T06:15:13Z

Pull request #38330 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

seungjin-yang · 2022-06-19T06:22:14Z

Hi @perrotta, this PR not only turns on propagation error cuts but also provides a more reliable GEM detection efficiency measurement. So, I want to backport this PR to 12_3_X.
Also, I removed GEMOfflineDQMBase, which was replaced by GEMDQMEfficiencySourceBase. Thank you for pointing this out!

perrotta · 2022-06-19T11:41:53Z

please test

cmsbuild · 2022-06-19T16:55:00Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dc1332/25612/summary.html
COMMIT: 42b08cb
CMSSW: CMSSW_12_3_X_2022-06-19-0000/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38330/25612/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3622198
DQMHistoTests: Total failures: 13
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3622162
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -1085.1599999999999 KiB( 48 files compared)
DQMHistoSizes: changed ( 11634.0,... ): -30.252 KiB GEM/Efficiency
DQMHistoSizes: changed ( 23234.0,... ): -57.619 KiB GEM/Efficiency
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
DQMHistoSizes: changed ( 35034.0,... ): -116.275 KiB GEM/Efficiency
Checked 205 log files, 45 edm output root files, 49 DQM output files
TriggerResults: no differences found

emanueleusai · 2022-06-21T19:03:01Z

+1

cmsbuild · 2022-06-21T19:03:19Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-06-23T05:13:34Z

+1

Identical backport of GEM Online & Offline Efficiency Update #37954, already tested at P5
It fixes and simplifies the DQM plots for GEM

backport cms-sw#37954 to 12_3_X

7721163

cmsbuild added this to the CMSSW_12_3_X milestone Jun 11, 2022

cmsbuild added dqm-pending orp-pending pending-signatures tests-pending labels Jun 11, 2022

cmsbuild added tests-started and removed tests-pending labels Jun 13, 2022

cmsbuild added tests-approved and removed tests-started labels Jun 13, 2022

cmsbuild added the gem label Jun 14, 2022

cmsbuild added the backport-ok label Jun 14, 2022

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jun 18, 2022

remove deprecated files

42b08cb

cmsbuild removed dqm-approved fully-signed labels Jun 19, 2022

cmsbuild added dqm-pending pending-signatures tests-pending and removed tests-approved labels Jun 19, 2022

cmsbuild added tests-started and removed tests-pending labels Jun 19, 2022

cmsbuild added tests-approved and removed tests-started labels Jun 19, 2022

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jun 21, 2022

cmsbuild added orp-approved and removed orp-pending labels Jun 23, 2022

cmsbuild merged commit cf69acf into cms-sw:CMSSW_12_3_X Jun 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GEM Online & Offline Efficiency Update (backport of #37954, 12_3_X) #38330

GEM Online & Offline Efficiency Update (backport of #37954, 12_3_X) #38330

seungjin-yang commented Jun 11, 2022

cmsbuild commented Jun 11, 2022 •

edited

Loading

seungjin-yang commented Jun 11, 2022

emanueleusai commented Jun 13, 2022

cmsbuild commented Jun 13, 2022

emanueleusai commented Jun 14, 2022

emanueleusai commented Jun 14, 2022

emanueleusai commented Jun 14, 2022

emanueleusai commented Jun 18, 2022

emanueleusai commented Jun 18, 2022

cmsbuild commented Jun 18, 2022

perrotta commented Jun 18, 2022

PR description:

cmsbuild commented Jun 19, 2022

seungjin-yang commented Jun 19, 2022

perrotta commented Jun 19, 2022

cmsbuild commented Jun 19, 2022

emanueleusai commented Jun 21, 2022

cmsbuild commented Jun 21, 2022

perrotta commented Jun 23, 2022

GEM Online & Offline Efficiency Update (backport of #37954, 12_3_X) #38330

GEM Online & Offline Efficiency Update (backport of #37954, 12_3_X) #38330

Conversation

seungjin-yang commented Jun 11, 2022

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Jun 11, 2022 • edited Loading

seungjin-yang commented Jun 11, 2022

emanueleusai commented Jun 13, 2022

cmsbuild commented Jun 13, 2022

Comparison Summary

emanueleusai commented Jun 14, 2022

emanueleusai commented Jun 14, 2022

emanueleusai commented Jun 14, 2022

emanueleusai commented Jun 18, 2022

emanueleusai commented Jun 18, 2022

cmsbuild commented Jun 18, 2022

perrotta commented Jun 18, 2022

PR description:

cmsbuild commented Jun 19, 2022

seungjin-yang commented Jun 19, 2022

perrotta commented Jun 19, 2022

cmsbuild commented Jun 19, 2022

Comparison Summary

emanueleusai commented Jun 21, 2022

cmsbuild commented Jun 21, 2022

perrotta commented Jun 23, 2022

cmsbuild commented Jun 11, 2022 •

edited

Loading