[12_3_X] Fix ThroughputServiceClient.cc unsigned variables overflow #38287
Conversation
|
A new Pull Request was created by @pmandrik for CMSSW_12_3_X. It involves the following packages:
@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Will there be a 12_4_X backport? |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9bec22/25363/summary.html Comparison SummarySummary:
|
|
+1 |
cmsbuild
added
fully-signed
hlt-approved
and removed
hlt-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
| int64_t first = sourced->FindFirstBinAbove(0.); | ||
| int64_t last = sourced->FindLastBinAbove(0.); |
There was a problem hiding this comment.
| int64_t first = sourced->FindFirstBinAbove(0.); | |
| int64_t last = sourced->FindLastBinAbove(0.); | |
| auto first = sourced->FindFirstBinAbove(0.); | |
| auto last = sourced->FindLastBinAbove(0.); |
| booker.setCurrentFolder(folder); | ||
| // (re)book and fill .../average_sourced | ||
| average = booker.book1D("average_sourced", "Throughput (sourced events)", (int)width, avg_min, avg_max)->getTH1F(); | ||
| for (unsigned int i = first; i <= last; ++i) | ||
| for (int64_t i = std::max(first, (int64_t)0); i <= last; ++i) |
There was a problem hiding this comment.
| for (int64_t i = std::max(first, (int64_t)0); i <= last; ++i) | |
| if(first >= 0) | |
| for (auto i = first; i <= last; ++i) |
| @@ -135,7 +135,7 @@ void ThroughputServiceClient::fillSummaryPlots(DQMStore::IBooker &booker, DQMSto | |||
| booker.setCurrentFolder(folder); | |||
| // (re)book and fill .../average_retired | |||
| average = booker.book1D("average_retired", "Throughput (retired events)", (int)width, avg_min, avg_max)->getTH1F(); | |||
| for (unsigned int i = first; i <= last; ++i) | |||
| for (int64_t i = std::max(first, (int64_t)0); i <= last; ++i) | |||
There was a problem hiding this comment.
| for (int64_t i = std::max(first, (int64_t)0); i <= last; ++i) | |
| if(first >= 0) | |
| for (auto i = first; i <= last; ++i) |
|
type bugfix |
|
+1 |
PR description:
TH1F FindFirstBinAbove() can return -1 [0] when hist is empty overflowing unsigned variables uint64_t first and uint64_t last. The next two loops for (unsigned int i = first; i <= last; ++i) became very long and hlt_clientPB DQM client is not able to exit in time when the run is ended. Affect Online DQM operation.
PR validation:
[0] https://root.cern.ch/doc/master/classTH1.html#a63960594f84aea92e5fa2d5129b49007
if this PR is a backport please specify the original PR and why you need to backport that PR:
backport of #38282