Update DQM beam clients playback machine type check

[pmandrik]

PR description:

update DQM beam* clients to use available config data to check if machine is playback or production instead of path to the CMSSW folder (which is unsafe).

PR validation:

Tested at P5 playback DQM

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38262/30415

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @pmandrik for master.

It involves the following packages:

• DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@battibass, @threus, @batinkov, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[pmandrik]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c0676/25318/summary.html
COMMIT: 2eade3d
CMSSW: CMSSW_12_5_X_2022-06-06-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38262/25318/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @grasph Bug fix for the EcalDumpRaw expert tool, which is not used in the standard workflow. #38176
• @jeongeun Cleanup redundant edm ParameterSet exist in RecoLuminosity #38218

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c0676/25318/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0c0676/25318/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3651603
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3651573
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[francescobrivio]

Hi @pmandrik,
Thanks a lot for this!
I have only two questions/comments:

• Question: what happens when running locally (e.g. on lxplus)?
• Comment: you will also need a 12_4_X backport right? Deadline for 12_4_0 is next Tuesday. I can help opening the 12_4_Xbackport if needed, just let me know!

[pmandrik]

Hi, @francescobrivio , locally at the lxplus process.isDqmPlayback.value is False and process.isDqmProduction.value should be False too. Thank you for the reminder, I'll create backport for 12_4_X when this one will be approved. Backport for 12_3_X is just requred for testing and ongoing operations.

[francescobrivio]

Hi, @francescobrivio , locally at the lxplus process.isDqmPlayback.value is False and process.isDqmProduction.value should be False too.

Perfect thanks Petr! Then I'm fine with the changes proposed in this PR!

Thank you for the reminder, I'll create backport for 12_4_X when this one will be approved. Backport for 12_3_X is just requred for testing and ongoing operations.

When are you planning to test this in P5?

[pmandrik]

Hi, @francescobrivio , locally at the lxplus process.isDqmPlayback.value is False and process.isDqmProduction.value should be False too.

Perfect thanks Petr! Then I'm fine with the changes proposed in this PR!

Thank you for the reminder, I'll create backport for 12_4_X when this one will be approved. Backport for 12_3_X is just requred for testing and ongoing operations.

When are you planning to test this in P5?

the PR backport was already tested at P5 and included for ongoing playback operations

[francescobrivio]

the PR backport was already tested at P5 and included for ongoing playback operations

Ah yes I see it now in the playback logs! thanks!
All good from my side then!

+1

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[qliphy]

@pmandrik please also backport this to 12_4_X

[francescobrivio]

@pmandrik please also backport this to 12_4_X

@qliphy @pmandrik please see #38312

[pmandrik]

@pmandrik please also backport this to 12_4_X

@qliphy @pmandrik please see #38312

Hi, thank you for the help!