-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guard against uint16_t
overflows of Pixel ADC values [12_4_X
]
#38148
guard against uint16_t
overflows of Pixel ADC values [12_4_X
]
#38148
Conversation
A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_12_4_X. It involves the following packages:
@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
type bugfix |
test parameters:
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-daf81c/25118/summary.html GPU Comparison SummarySummary:
Comparison SummarySummary:
|
type trk |
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #38113
PR description:
See the original PR for the documentation of this change.
This PR prevents the possibility of a crash at HLT by avoiding the
uint16_t
-overflow of values used in the pixel local reconstruction.PR validation:
Relies on the testing done for the original PR.
If this PR is a backport, please specify the original PR and why you need to backport that PR:
#38113