Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a missing parameter in the dqmSaver in the hltHarvesting test [12.4.x] #38133

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 31, 2022

PR description:

Fix the HLTrigger/Configuration/test/hltHarvesting.py test file, setting the missing dqmSaver.workflow to "/DQM/HLT/Online".

PR validation:

hltHarvesting.py now runs.

Backport

Backport of #38132

@cmsbuild
Copy link
Contributor

cmsbuild commented May 31, 2022

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_12_4_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented May 31, 2022

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented May 31, 2022

backport #38132

@fwyzard
Copy link
Contributor Author

fwyzard commented May 31, 2022

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31669e/25093/summary.html
COMMIT: 761f6c4
CMSSW: CMSSW_12_4_X_2022-05-30-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38133/25093/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3668385
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3668349
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 1, 2022

+1

@cmsbuild cmsbuild merged commit a189a1d into cms-sw:CMSSW_12_4_X Jun 1, 2022
@fwyzard fwyzard deleted the fix_HLTrigger_Configuration_hltHarvesting branch July 31, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants