[12_3_X] Compute muon index bits using idx from dataformat

[dinyar]

PR description:

We currently compute the muon index within the link from the position in the vector, however this is packed densely and during cosmics the EMTF always sends muon stubs in third position (even if the second position is free), causing a mismatch in index bits.

Therefore we now assign the muon index on the link in the uGMT unpacker and use that index if it is set. The behaviour when the muIdx field is not explicitly set should be identical to the current one.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #38035 as requested in #38035 (comment).

Would like this in for the DQM at P5.

[cmsbuild]

A new Pull Request was created by @dinyar (Dinyar Rabady) for CMSSW_12_3_X.

It involves the following packages:

• DataFormats/L1TMuon (l1)
• EventFilter/L1TRawToDigi (l1)
• L1Trigger/L1TMuon (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @rovere, @thomreis, @eyigitba this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Compute muon index bits using idx from dataformat #38035

[epalencia]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab687d/25066/summary.html
COMMIT: ba6e473
CMSSW: CMSSW_12_3_X_2022-05-29-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38117/25066/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3627388
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3627352
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 48 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[epalencia]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

backport of #38035

[perrotta]

This was merged succesfully in master since CMSSW_12_5_X_2022-05-30-2300, and as such liable to being backported in 12_3_X
However, I am a bit reluctant to merge it right now, because this changes the DataFormat, and it would cause the next 12_3_X release to be a full release rather than a (faster) patch release. It is not yet clear to me whether a quick patch release will be requested before the next stable collisions of Friday, and I would not like preventing it because of this possible merge.
Of course, if @cms-sw/l1-l2 deems this PR necessary (let say, highly welcome) for the data taking we will merge anyhow and afford the extra time needed to build a full release with it.
In any case, we can discuss it at today's orp meeting.

[dinyar]

Hi Andrea,

Enrique is going to reply in the ORP meeting, but here for completeness: It's not at all urgent (the bug that's fixed by it has been around since the beginning of the Phase-1 upgrade and only affects us during cosmics). So I'd say we can either merge it next week or close the PR if DQM has anyway moved to 12_4_x by then..

Cheers,
Dinyar

[perrotta]

+1

• It can enter the next possible 12_3_X full release