Remove HLT process name out from L1CaloTrigger

[srimanob]

PR description:

Currently, L1 step can't run if process name is not HLT. Following code check by @Martin-Grunewald the process name is hardcode in L1Trigger/L1CaloTrigger/python/. This PR is to remove them out as the L1 step should not depend on HLT process (name). However, this will need confirmation from L1T expert.

Note that, it is unclear to me if l1EGammaCrystalsProducer_cfi.py is still in used.

(*)
https://docs.google.com/document/d/1DU5MzzIeyGyXYbzTtfreCnsZ9FAmbI6_daFy0vklTos/edit#bookmark=id.qcivq83cr9gj

PR validation:

Test with wf 39434.75 . With the following modified cmsDriver of step2, job is running fine.
cmsDriver.py step2 -s DIGI:pdigi_valid,L1TrackTrigger,L1,DIGI2RAW --conditions auto:phase2_realistic_T21 --datatier GEN-SIM-DIGI-RAW -n 10 --eventcontent FEVTDEBUGHLT --geometry Extended2026D88 --era Phase2C17I13M9 --io DigiTrigger_HLT75e33_2026D88.io --python DigiTrigger_HLT75e33_2026D88_noHLT.py -n 50 --no_exec --filein file:step1.root --fileout file:step2_noHLT.root --nThreads 8

if this PR is a backport please specify the original PR and why you need to backport that PR:

No need of backport.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37988/30058

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

• L1Trigger/L1CaloTrigger (upgrade, l1)

@rekovic, @epalencia, @cmsbuild, @AdrianoDee, @srimanob, @cecilecaillol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @beaucero, @trtomei this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[srimanob]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-582e0a/24801/summary.html
COMMIT: 8660379
CMSSW: CMSSW_12_5_X_2022-05-17-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37988/24801/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-582e0a/11634.301_TTbar_14TeV+2021_Run3FS+TTbar_14TeV_TuneCP5_GenSim+HARVESTNano

Summary:

• No significant changes to the logs found
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3672456
• DQMHistoTests: Total failures: 20
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3672414
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[Martin-Grunewald]

Thanks @srimanob

[cecilecaillol]

+l1

[srimanob]

Hi @cecilecaillol

Is l1EGammaCrystalsProducer_cfi.py still in use?

Thx.

[cecilecaillol]

@srimanob It is used in the sim emulator sequence https://github.com/cms-sw/cmssw/blob/master/L1Trigger/Configuration/python/SimL1Emulator_cff.py#L87-L88

[srimanob]

Hi @cecilecaillol

I see from the link you point to is on L1EGammaCrystalsEmulatorProducer_cfi, but not l1EGammaCrystalsProducer_cfi.

[cecilecaillol]

@srimanob l1EGammaCrystalsProducer_cfi is not used anymore, we always take the emulated version

[srimanob]

Thanks @cecilecaillol for confirmation. I then remove the obsolete/unused config to avoid confusion.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37988/30375

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #37988 was updated. @rekovic, @epalencia, @cmsbuild, @AdrianoDee, @srimanob, @cecilecaillol can you please check and sign again.

[srimanob]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-582e0a/25240/summary.html
COMMIT: cde8d0c
CMSSW: CMSSW_12_5_X_2022-06-02-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37988/25240/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3649923
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3649887
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[srimanob]

+Upgrade

Technical PR to remove "HLT"-process name dependence.

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1