[12.3.X] Fix Tracker Alignment Payload writing

[mmusich]

backport of #37925

PR description:

The goal of this PR is to fix a bug inadvertently introduced at #36076 (aimed to migrate Alignment codes to new PoolDBOutputService methods).
Moving to usage of instances instead of pointers led to the GeometryAligner::removeGlobalTransform call (to remove global roto-translations after computation of the alignment corrections) to be ineffective. This in turn lead to large spurious rotations and shifts of the alignment output geometry with respect to the input one.
This is fixed here in commit eb88897.

PR validation:

Run a small alignment campaign (copied from mp3495) and compared the output payloads with respect to the input one. Results (obtained from the payload inspector) are collected:

• here: before the fix
• here: after the fix

Here is a couple of plots selected from the folders above (notice the scale).

Before the fix	After the fix

if this PR is a backport please specify the original PR and why you need to backport that PR:

partial backport of #37925

[mmusich]

type bug-fix

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_3_X.

It involves the following packages:

• Alignment/CommonAlignmentProducer (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@pakhotin, @mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix Tracker Alignment Payload writing  #37925

[mmusich]

type trk

[mmusich]

@cmsbuild, please test

[francescobrivio]

urgent

• mandatory for first stable collisions

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25e3a6/24666/summary.html
COMMIT: eb88897
CMSSW: CMSSW_12_3_X_2022-05-12-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37926/24666/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3696954
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3696927
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1