LLP GenFilter based on transverse displacement and pdgId - backport #37669

[Raffaella07]

###PR description:
The filter selects particles based on transverse displacement (by means of a lower and/or upper cut) and pdgIds.
The filter is developed for searches of long lived HNLs in B meson decays (@rmanzoni @pandolf @amlyon)

The filter is included in the /plugins subdirectory of GeneratorInterface/GenFilters .

###PR validation:
Filter behavior can be tested in the test subdirectory of GeneratorInterface/GenFilters through the module test_MCLongLivedFilter_cfg.py

Backporting #37669

[cmsbuild]

A new Pull Request was created by @Raffaella07 (raffaellatramontano) for CMSSW_10_6_X.

It involves the following packages:

• GeneratorInterface/GenFilters (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b7308/24581/summary.html
COMMIT: 8107d91
CMSSW: CMSSW_10_6_X_2022-05-08-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37891/24581/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 3215686
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3215350
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 143 log files, 29 edm output root files, 35 DQM output files
• TriggerResults: no differences found

[SiewYan]

@smuzaffar , sorry if this has been asked many time..

could you point me to the instruction/documentation on how to trigger user addOn test, for example trigger this test_MCLongLivedFilter_cfg.py with cms-bot command?

thanks..

[smuzaffar]

@SiewYan , bot runs all tests which are mentioned in cmssw/Subsystem/Package/test/Buildfile.xml. If you need to run cmsRun test_MCLongLivedFilter_cfg.py then please add GeneratorInterface/GenFilters/test/BuildFile.xml with following contents

<test name="test_MCLongLivedFilter_cfg" command="cmsRun $${SCRAM_TEST_PATH}/test_MCLongLivedFilter_cfg.py"/>

[SiewYan]

@Raffaella07 , could you use @smuzaffar 's advice on your PR, add the mentioned line on top of your PR? I will re-trigger the test. The test result is needed for the record.

Thanks!

[SiewYan]

@SiewYan , bot runs all tests which are mentioned in cmssw/Subsystem/Package/test/Buildfile.xml. If you need to run cmsRun test_MCLongLivedFilter_cfg.py then please add GeneratorInterface/GenFilters/test/BuildFile.xml with following contents

<test name="test_MCLongLivedFilter_cfg" command="cmsRun $${SCRAM_TEST_PATH}/test_MCLongLivedFilter_cfg.py"/>

Thank you @smuzaffar , i will keep that in mind.

[perrotta]

@Raffaella07 , could you use @smuzaffar 's advice on your PR, add the mentioned line on top of your PR? I will re-trigger the test. The test result is needed for the record.

Thanks!

Well, I'd rather do it in the master, so that it will get propagated to all future releases.
For the backports it is enough to confirm that it runs when it is merged, by running the script by hand just once

[SiewYan]

+1

Thanks, I'll sign this off then. @Saptaparna

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[Saptaparna]

Thanks, Siewyan!