[12.3.X] Fix SiPixel Layer 1 efficiency calculation

[mmusich]

backport of #37778

PR description:

Following #35058 a few fixes/changes in L1 efficiency calculation/hit classification are introduced: reject TrajectoryMeasurements w/o pixel hit, fix min.distance calculation and filling of the inactive hits, initialize valid/missing/passcuts_hit for each loop iteration.

Changes expected in L1 efficiency and hit classification.

PR validation:

Matrix run, no issue.

if this PR is a backport please specify the original PR and why you need to backport that PR:

verbatim backport of #37778

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_3_X.

It involves the following packages:

• DQM/SiPixelPhase1Track (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@arossi83, @hdelanno, @sroychow, @fioriNTU, @jandrea, @idebruyn, @threus this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix SiPixel Layer 1 efficiency calculation #37778

[mmusich]

@cmsbuild, please test

[mmusich]

type trk

[mmusich]

type bug-fix

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a4c07c/24528/summary.html
COMMIT: dc0140e
CMSSW: CMSSW_12_3_X_2022-05-08-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37859/24528/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3696087
• DQMHistoTests: Total failures: 91
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3695974
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Fix to DQM already merged in master since CMSSW_12_4_X_2022-05-08-2300