Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BTV DQM Updates #37832

Merged
merged 2 commits into from
May 21, 2022
Merged

BTV DQM Updates #37832

merged 2 commits into from
May 21, 2022

Conversation

terrill37
Copy link
Contributor

PR description:

Changes include monitoring of DeepCSV variables in the BTVHLTOfflineSource plugin along with removing unnecessary variable monitoring. Also introduced a tag and probe plugin producing output to the HLT/BTV directory path to the output DQM directory.

PR validation:

performed the following test using runTheMatrix.py -l limited -i all --ibeos in lxplus.

bjetTnP_update_v3.pptx

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2022

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37832/29751

  • This PR adds an extra 48KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37832/29752

  • This PR adds an extra 52KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2022

A new Pull Request was created by @terrill37 (Wesley Terrill) for master.

It involves the following packages:

  • DQMOffline/Trigger (dqm)
  • HLTriggerOffline/Btag (dqm)
  • HLTriggerOffline/Common (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@AlexDeMoor, @emilbols, @HuguesBrun, @missirol, @mtosi, @jhgoh, @JyothsnaKomaragiri, @sscruz, @Fedespring, @andrzejnovak, @demuller, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2022

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a94b7f/24518/summary.html
COMMIT: 9747a0c
CMSSW: CMSSW_12_4_X_2022-05-07-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37832/24518/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 64 COMPILER='llvm compile'

See details on the summary page.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37832/30037

  • This PR adds an extra 44KB to repository

@cmsbuild
Copy link
Contributor

Pull request #37832 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

@perrotta perrotta changed the title BTV Updates BTV DQM Updates May 17, 2022
@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a94b7f/24811/summary.html
COMMIT: 31cea07
CMSSW: CMSSW_12_5_X_2022-05-17-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37832/24811/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a94b7f/11634.301_TTbar_14TeV+2021_Run3FS+TTbar_14TeV_TuneCP5_GenSim+HARVESTNano

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3647505
  • DQMHistoTests: Total failures: 91
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3647391
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -98567.68400000001 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -16427.948 KiB HLT/BTV
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1157e36 into cms-sw:master May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants