JME DQM updates for Run3 (12_4_X)

[esiam]

#### PR description:

Modify code for DQM, Validation and Harvesting steps for JME group.

Add kinematic variables, remove quantities that are not usefull, add efficiency plots and clean up files with trigger paths. An overview can be found here. The changes were discussed with the JME trigger group ( @pallabidas , @sparedes) and also presented to the STEAM meeting ( @lbenato, @aknayak, @milosdjordjevic )

#### PR validation:

The changes were tested by running the DQM and Harvesting steps on RelVal samples. Besides they were tested by using the RunTheMatrix.py -l 11634.0.

Please let me know, if more information is needed.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37725/29570

• This PR adds an extra 48KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37725/29570/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37725/29570/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37725/29571

• This PR adds an extra 48KB to repository

[cmsbuild]

A new Pull Request was created by @esiam for master.

It involves the following packages:

• DQMOffline/Trigger (dqm)
• HLTriggerOffline/JetMET (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@HuguesBrun, @mtosi, @Fedespring, @missirol, @sscruz, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46f4e8/24339/summary.html
COMMIT: 9bab8d5
CMSSW: CMSSW_12_4_X_2022-04-29-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37725/24339/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3682108
• DQMHistoTests: Total failures: 1412
• DQMHistoTests: Total nulls: 7414
• DQMHistoTests: Total successes: 3673260
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 119879.86399999999 KiB( 48 files compared)
• DQMHistoSizes: changed ( 1000.0 ): -7.744 KiB HLT/JME
• DQMHistoSizes: changed ( 11634.0,... ): 16759.792 KiB HLT/JME
• DQMHistoSizes: changed ( 11634.0,... ): 2783.765 KiB HLT/EXO
• DQMHistoSizes: changed ( 11634.0,... ): 400.039 KiB HLT/B2G
• DQMHistoSizes: changed ( 11634.0,... ): 46.498 KiB HLT/HLTJETMET
• DQMHistoSizes: changed ( 11634.0,... ): -8.826 KiB HLT/HT
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[qliphy]

@esiam please squash the commits into one

[cmsbuild]

Pull request #37725 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

[esiam]

@perrotta thank you very much for your feedback. I am sorry for the late response.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37725/29630

• This PR adds an extra 40KB to repository

[cmsbuild]

Pull request #37725 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

[perrotta]

please test

[perrotta]

@esiam I took the liberty to modify the title in order to have it a little more descriptive: please modify it further if you don't like it

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46f4e8/24360/summary.html
COMMIT: 4780268
CMSSW: CMSSW_12_4_X_2022-05-01-0000/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37725/24360/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3690820
• DQMHistoTests: Total failures: 1418
• DQMHistoTests: Total nulls: 7414
• DQMHistoTests: Total successes: 3681966
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 119879.86399999999 KiB( 48 files compared)
• DQMHistoSizes: changed ( 1000.0 ): -7.744 KiB HLT/JME
• DQMHistoSizes: changed ( 11634.0,... ): 16759.792 KiB HLT/JME
• DQMHistoSizes: changed ( 11634.0,... ): 2783.765 KiB HLT/EXO
• DQMHistoSizes: changed ( 11634.0,... ): 400.039 KiB HLT/B2G
• DQMHistoSizes: changed ( 11634.0,... ): 46.498 KiB HLT/HLTJETMET
• DQMHistoSizes: changed ( 11634.0,... ): -8.826 KiB HLT/HT
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1