Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_3_X] Add streamerFile-based unitTest for BeamSpotOnlineHLT DQM client #37688

Conversation

francescobrivio
Copy link
Contributor

PR description:

Backport of #37667
This PR adds the unitTest for the DQM BeamSpotHLT client (beamhlt_dqm_sourceclient-live_cfg.py).
The client requires to be run on streamer files (in production it runs on an ad hoc stream streamDQMOnlineBeamspot) which are added in cms-data/DQM-Integration#1

PR validation:

UnitTest in the master PR runs successfully.
As I mentioned already this PR does NOT modify the production behavior, it just adds a new unitTest.
I opened the PR in case the DQM team (@cms-sw/dqm-l2) wants to test it in a replay (although I'm not sure
how meaningful it would be).

Backport:

Backport of #37667

@francescobrivio
Copy link
Contributor Author

backport of #37667

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 26, 2022

A new Pull Request was created by @francescobrivio for CMSSW_12_3_X.

It involves the following packages:

  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@threus, @batinkov, @battibass this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

test parameters:

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f7e902/24235/summary.html
COMMIT: 6d7435d
CMSSW: CMSSW_12_3_X_2022-04-26-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37688/24235/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3697135
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3697105
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3e98a1d into cms-sw:CMSSW_12_3_X Apr 27, 2022
@francescobrivio francescobrivio deleted the alca-addUnitTestforBeamspot_12_3_X branch May 1, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants